58227[TASK] Limit number of items per XML sitemap
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Guido Schmechel +1
- Richard Haeser +1
-
Verified V +2
- Susi Moog +2
- Guido Schmechel +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/seo/Classes/XmlSitemap/AbstractXmlSitemapDataProvider.php6+51 −1
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php5+60 −59
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php3+35 −13
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapDataProviderInterface.php1+15 −0
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php6+23 −4
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/constants.typoscript+11 −0
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.typoscript2+2 −2
- typo3/sysext/seo/Resources/Private/Templates/XmlSitemap/Index.xml1+1 −1
- typo3/sysext/seo/Resources/Private/Templates/XmlSitemap/Sitemap.xml+6 −4
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapIndexTest.php3+19 −3
- typo3/sysext/seo/Tests/Unit/XmlSitemap/PagesXmlSitemapDataProviderTest.php1+77 −22
- composer.json+1 −1
- composer.lock+6 −6
Review log 4459
Show 2534 earlier messages
-
Richard Haeser uploaded patch set 1 09/08/18, 11:45
-
TYPO3com voted on patch set 1 V -1 09/08/18, 11:55 Completed build in 09m 35s on Sat, 8 Sep, 01:55 PM Test Summary: 3 of 36211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27899
-
Richard Haeser uploaded patch set 2 09/08/18, 17:53
-
TYPO3com voted on patch set 2 V +1 09/08/18, 18:02 Completed build in 09m 05s on Sat, 8 Sep, 08:02 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27909
-
Richard Haeser uploaded patch set 3 09/09/18, 05:51
-
TYPO3com voted on patch set 3 V +1 09/09/18, 06:02 Completed build in 10m 15s on Sun, 9 Sep, 08:02 AM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27912
-
Jigal van Hemert commented on patch set 3 CR +1 09/09/18, 12:26
-
Guido Schmechel commented on patch set 3 09/09/18, 19:07
XmlSitemapRenderer.php:77UnresolvedgetNumberOfPages() -> P -
Richard Haeser uploaded patch set 4 09/10/18, 20:00
-
TYPO3com voted on patch set 4 V +1 09/10/18, 20:10 Completed build in 09m 47s on Mon, 10 Sep, 10:10 PM Test Summary: 35875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27959
-
Georg Großberger commented on patch set 4 09/11/18, 15:33
XmlSitemapRenderer.php:76I would prefer a method definition in the XmlSitemapDataProviderInterface or separate interface like "PaginationAwareDataProvider". That way the API is clear and and easier to follow. -
Susi Moog commented on patch set 4 CR -1 09/13/18, 19:12
PagesXmlSitemapDataProvider.php:99why this replace magic? especially if you are replacing and/or the same way that's probably changing semantics from what the user intended. better let the query fail on wrong config.XmlSitemapRenderer.php:76ReplyIf - as I understand the code - the getNumberOfPages is not required, I'd prefer the separate interface way. -
Richard Haeser commented on patch set 4 09/13/18, 19:39
XmlSitemapRenderer.php:76ReplyIn the end: you want people to prevent exceeding google limits, so maybe we can just add it to the default interface. -
Richard Haeser uploaded patch set 5 09/13/18, 20:05
-
TYPO3com voted on patch set 5 V +1 09/13/18, 20:16 Completed build in 10m 53s on Thu, 13 Sep, 10:16 PM Test Summary: 35920 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28062
-
Markus Klein commented on patch set 5 09/15/18, 12:47
limited toAbstractXmlSitemapDataProvider.php:118not neededXmlSitemapRenderer.php:77spaces around pls -
Richard Haeser commented on patch set 5 09/15/18, 12:47
On it -
Markus Klein commented on patch set 6 09/15/18, 12:48
Published edit on patch set 5. -
Markus Klein voted on patch set 6 CR +1 09/15/18, 12:49
-
TYPO3com voted on patch set 6 V +1 09/15/18, 12:56 Completed build in 07m 43s on Sat, 15 Sep, 02:56 PM Test Summary: 35911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28117
-
Richard Haeser voted on patch set 6 V +1 CR +1 09/16/18, 10:18
-
Guido Schmechel commented on patch set 6 09/16/18, 10:51
To discuss: Should we config the number of items? (1000)Unresolved
paginatedAbstractXmlSitemapDataProvider.php:114UnresolvedThis could be also allow negative page values? Is that desirable?PagesXmlSitemapDataProvider.php:114UnresolvedIs this ordering neccessary? We had no index on this tablefield. I think about performance -
Richard Haeser commented on patch set 6 09/16/18, 11:10
I can't think on a use-case that you want to alter the amount of items per sitemap for pages. The limit of Google is currently 50k per sitemap and more important: it shouldn't timeout. Besides that, the most important one is your XML Sitemap index. That is the one that is send to your search engine. And I'm a big fan of making choices instead of options ;-) -
Richard Haeser uploaded patch set 7 09/16/18, 11:19
-
TYPO3com voted on patch set 7 V +1 09/16/18, 11:31 Completed build in 12m 26s on Sun, 16 Sep, 01:31 PM Test Summary: 35911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28168
-
Guido Schmechel voted on patch set 7 V +1 CR +1 09/16/18, 11:46
-
Richard Haeser updated the commit message in patch set 8 09/16/18, 11:50
-
Guido Schmechel voted on patch set 8 V +1 CR +1 09/16/18, 11:54
-
TYPO3com voted on patch set 8 V +1 09/16/18, 12:01 Completed build in 10m 44s on Sun, 16 Sep, 02:01 PM Test Summary: 35911 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28170
-
Markus Klein commented on patch set 8 09/16/18, 22:47
AbstractXmlSitemapDataProvider.php:114parentheses not needed -
Markus Klein commented on patch set 9 09/16/18, 22:48
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V +1 09/16/18, 22:58 Completed build in 10m 19s on Mon, 17 Sep, 12:58 AM Test Summary: 35938 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28205
-
Benjamin Kott commented on patch set 9 CR -1 09/17/18, 11:53
setup.typoscript:42can we please move these to typoscript constants? -
Benjamin Kott commented on patch set 9 09/17/18, 11:53
setup.typoscript:43can we please move these to typoscript constants?
-
Jörg Bösche uploaded patch set 10 09/17/18, 12:02
-
TYPO3com voted on patch set 10 V -1 09/17/18, 12:10 Completed build in 08m 09s on Mon, 17 Sep, 02:10 PM Test Summary: 3 of 36284 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28222
-
Jörg Bösche uploaded patch set 11 09/17/18, 12:22
-
TYPO3com voted on patch set 11 V -1 09/17/18, 12:35 Completed build in 12m 11s on Mon, 17 Sep, 02:35 PM Test Summary: 3 of 36284 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28226
-
Oliver Hader uploaded patch set 12 09/17/18, 14:30
-
Richard Haeser commented on patch set 12 09/17/18, 14:34
AbstractXmlSitemapDataProvider.php:114It is still possible to do a -1 page param -
TYPO3com voted on patch set 12 V +1 09/17/18, 14:41 Completed build in 10m 26s on Mon, 17 Sep, 04:41 PM Test Summary: 35936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28233
-
Jörg Bösche commented on patch set 13 09/17/18, 15:31
Published edit on patch set 12. -
TYPO3com voted on patch set 13 V +1 09/17/18, 15:39 Completed build in 08m 37s on Mon, 17 Sep, 05:39 PM Test Summary: 35936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28237
-
Markus Klein commented on patch set 13 09/17/18, 18:16
AbstractXmlSitemapDataProvider.php:114do we know that this is always set? otherwise we need `?? 0`PagesXmlSitemapDataProvider.php:111I prefer having that in 1 lineRecordsXmlSitemapDataProvider.php:42is this always set?RecordsXmlSitemapDataProvider.php:42should be [], to have the same datatypeIndex.xml:6nitpick: remove space -
Richard Haeser uploaded patch set 14 09/17/18, 19:48
-
TYPO3com voted on patch set 14 V +1 09/17/18, 19:57 Completed build in 08m 52s on Mon, 17 Sep, 09:57 PM Test Summary: 35936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28246
-
Jörg Bösche voted on patch set 14 V +1 CR +1 09/17/18, 20:05
-
Markus Klein voted on patch set 14 CR +1 09/17/18, 22:31
-
Susi Moog commented on patch set 14 CR -1 09/18/18, 07:01
AbstractXmlSitemapDataProvider.php:4add copyright notice please.PagesXmlSitemapDataProvider.php:121is this still used?RecordsXmlSitemapDataProvider.php:4add missing copyright pleaseXmlSitemapDataProviderInterface.php:4add missing copyright pleaseXmlSitemapRenderer.php:4you know by now ;)XmlSitemapIndexTest.php:5...PagesXmlSitemapDataProviderTest.php:4you know... -
Richard Haeser commented on patch set 14 09/18/18, 07:15
On it -
Guido Schmechel uploaded patch set 15 09/18/18, 22:24
-
TYPO3com voted on patch set 15 V +1 09/18/18, 22:35 Completed build in 10m 20s on Wed, 19 Sep, 12:35 AM Test Summary: 35936 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28318
-
Susi Moog voted on patch set 15 CR +1 09/19/18, 10:07
-
Richard Haeser voted on patch set 15 V +1 CR +1 09/19/18, 19:16
-
Guido Schmechel voted on patch set 15 V +1 CR +1 09/19/18, 19:59
-
Susi Moog voted on patch set 15 V +2 CR +2 09/19/18, 21:43
-
Susi Moog merged patch set 16 09/19/18, 21:43
-
Oliver Hader commented on patch set 16 09/25/18, 08:10
XmlSitemapIndexTest.php:65Is the content length check really required here? Or would be be enough to check this header is available and positive? -
Richard Haeser commented on patch set 16 09/25/18, 08:26
XmlSitemapIndexTest.php:65ReplyWel the header only is enough I guess. The length is not necessary. Should I create a patch for it, or do you incorporate it in another patch?
PagesXmlSitemapDataProvider.php:83