58229[BUGFIX] Resolve correct page in slug validation
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Susi Moog +1
- Andreas Wolf +1
-
Verified V +2
- Oliver Hader +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+15 −10
- typo3/sysext/core/Classes/DataHandling/Model/EntityContext.php2new+80 −0
- typo3/sysext/core/Classes/DataHandling/Model/EntityPointer.phpnew+44 −0
- typo3/sysext/core/Classes/DataHandling/Model/EntityPointerLink.php6new+83 −0
- typo3/sysext/core/Classes/DataHandling/Model/EntityUidPointer.phpnew+91 −0
- typo3/sysext/core/Classes/DataHandling/Model/RecordState.php1new+164 −0
- typo3/sysext/core/Classes/DataHandling/Model/RecordStateFactory.phpnew+163 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+11 −5
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+27 −23
- typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php+7 −4
Review log 2330
Show 35 earlier messages
-
Oliver Hader uploaded patch set 1 09/08/18, 13:02
-
TYPO3com voted on patch set 1 V +1 09/08/18, 13:10 Completed build in 08m 03s on Sat, 8 Sep, 03:10 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27902
-
Oliver Hader rebased onto patch set 2 09/29/18, 21:24
-
TYPO3com voted on patch set 2 V +1 09/29/18, 21:32 Completed build in 08m 21s on Sat, 29 Sep, 11:32 PM Test Summary: 36184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28965
-
Benni Mack updated the commit message in patch set 3 09/30/18, 19:09
-
TYPO3com voted on patch set 3 V +1 09/30/18, 19:20 Completed build in 10m 29s on Sun, 30 Sep, 09:20 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29063
-
Frank Nägler voted on patch set 3 CR +1 09/30/18, 22:59
-
Andreas Kienast commented on patch set 3 CR -1 10/01/18, 16:59
on it -
Andreas Kienast uploaded patch set 4 10/01/18, 17:12
-
TYPO3com voted on patch set 4 V -1 10/01/18, 17:12 Completed build in 17s on Mon, 1 Oct, 07:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29206
-
Andreas Kienast uploaded patch set 5 10/01/18, 17:15
-
TYPO3com voted on patch set 5 V +1 10/01/18, 17:33 Completed build in 18m 28s on Mon, 1 Oct, 07:33 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29209
-
Christian Kuhn commented on patch set 5 10/01/18, 17:58
EntityContext.php:19please add comments. what is it good for, where is it used, in which context is it used, what's its purpose? who is supposed to consume it, who is not? similar for the other added classes: without any further information this is dead code since nobody knows / understands from the given - rather abstract - class names what this is meant to do. -
Jurian Janssen commented on patch set 5 10/01/18, 18:43
EntityContext.php:19ReplySeconded, as newer member I had to click through quite a bit to fully understand the purpose of these Entity classes. -
Oliver Hader commented on patch set 5 10/01/18, 18:45
That's why I handed it in as WIP... Sorry, I don't have time right now to adjust that since I'm still busy with other work that needs to be finished until tomorrow... -
Christian Kuhn commented on patch set 5 10/01/18, 18:58
all good olly. no pun. just a comment that comments could be improved ... there is no [WIP] tag on the commit message, so i thought you intended that for merge in the current phase. -
Benni Mack commented on patch set 5 10/01/18, 19:04
that was me. but maybe @andy can you explain what this patch is going to fix? -
Andreas Kienast commented on patch set 5 10/02/18, 06:15
> Patch Set 5: > > that was me. but maybe @andy can you explain what this patch is going to fix? Will try my best -
Andreas Kienast uploaded patch set 6 10/02/18, 06:43
-
TYPO3com voted on patch set 6 V +1 10/02/18, 06:57 Completed build in 14m 04s on Tue, 2 Oct, 08:57 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29258
-
Andreas Wolf commented on patch set 6 10/02/18, 07:35
Some nits picked…overshouldn't there be blank lines around each list item? Or at least before and after the list?EntityPointerLink.php:32"ancestor" implies this is always a parent–child relation, and we're traversing it bottom–up, correct?EntityPointerLink.php:60this can never actually return null, or?RecordState.php:24this could be an enumeration -
Andreas Kienast commented on patch set 6 10/02/18, 07:45
EntityPointerLink.php:32ReplyThere's not always a relation, but if there is one, then you're rightEntityPointerLink.php:60ReplyAck -
Andreas Kienast uploaded patch set 7 10/02/18, 07:50
-
TYPO3com voted on patch set 7 V +1 10/02/18, 08:01 Completed build in 11m 15s on Tue, 2 Oct, 10:01 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29264
-
Andreas Wolf commented on patch set 7 10/06/18, 08:53
EntityPointerLink.php:32ReplyI asked that because if it is so, we should probably document that in the class comment, to make this clear. Otherwise it's not really clear IMO…EntityPointerLink.php:60Replythanks for the fix :) -
Andreas Wolf voted on patch set 7 CR +1 10/06/18, 08:53
-
Daniel Goerz voted on patch set 7 V +1 10/25/18, 11:22
-
Susi Moog voted on patch set 7 CR +1 10/25/18, 11:39
-
Oliver Hader voted on patch set 7 V +2 CR +2 10/27/18, 20:35
-
Oliver Hader merged patch set 8 10/27/18, 20:37