Review main Merged

58229[BUGFIX] Resolve correct page in slug validation

Oliver Hader CR +2 V +2 Hard +685 −42 updated 10/27/18, 20:37

Commit message

The SlugHelper now receives an encapsulated RecordState object that
represents a record.

This allows fine-grained control over a record and helps resolving
related information, which is required to resolve slugs properly in a
case where e.g. the node ("parent") and language uid can occur multiple
times.

The RecordState contains:

- an EntityContext which describes a variant of a record by its language
  and workspace assignment

- a node object (EntityPointer) that points to the node (aka "parent") of
  the record

- a EntityUidPointer that describes the origin of the record by its table
  name and uid

The RecordStateFactory creates such RecordState objects and enriches them
with links (EntityPointerLink) that point to languages and versions, that
are also represented by EntityPointer implementations.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Susi Moog +1
    • Andreas Wolf +1
  • Verified V +2
    • Oliver Hader +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 2330

Show 35 earlier messages
  1. Oliver Hader uploaded patch set 1 09/08/18, 13:02

  2. TYPO3com voted on patch set 1 V +1 09/08/18, 13:10 Completed build in 08m 03s on Sat, 8 Sep, 03:10 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27902

  3. Oliver Hader rebased onto patch set 2 09/29/18, 21:24

  4. TYPO3com voted on patch set 2 V +1 09/29/18, 21:32 Completed build in 08m 21s on Sat, 29 Sep, 11:32 PM Test Summary: 36184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28965

  5. Benni Mack updated the commit message in patch set 3 09/30/18, 19:09

  1. TYPO3com voted on patch set 3 V +1 09/30/18, 19:20 Completed build in 10m 29s on Sun, 30 Sep, 09:20 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29063

  2. Frank Nägler voted on patch set 3 CR +1 09/30/18, 22:59

  3. Andreas Kienast commented on patch set 3 CR -1 10/01/18, 16:59

    on it
  4. Andreas Kienast uploaded patch set 4 10/01/18, 17:12

  5. TYPO3com voted on patch set 4 V -1 10/01/18, 17:12 Completed build in 17s on Mon, 1 Oct, 07:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29206

  6. Andreas Kienast uploaded patch set 5 10/01/18, 17:15

  7. TYPO3com voted on patch set 5 V +1 10/01/18, 17:33 Completed build in 18m 28s on Mon, 1 Oct, 07:33 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29209

  8. Christian Kuhn commented on patch set 5 10/01/18, 17:58

    EntityContext.php:19

    please add comments. what is it good for, where is it used, in which context is it used, what's its purpose? who is supposed to consume it, who is not? similar for the other added classes: without any further information this is dead code since nobody knows / understands from the given - rather abstract - class names what this is meant to do.
  9. Jurian Janssen commented on patch set 5 10/01/18, 18:43

    EntityContext.php:19 Reply

    Seconded, as newer member I had to click through quite a bit to fully understand the purpose of these Entity classes.
  10. Oliver Hader commented on patch set 5 10/01/18, 18:45

    That's why I handed it in as WIP... Sorry, I don't have time right now to adjust that since I'm still busy with other work that needs to be finished until tomorrow...
  11. Christian Kuhn commented on patch set 5 10/01/18, 18:58

    all good olly. no pun. just a comment that comments could be improved ... there is no [WIP] tag on the commit message, so i thought you intended that for merge in the current phase.
  12. Benni Mack commented on patch set 5 10/01/18, 19:04

    that was me. but maybe @andy can you explain what this patch is going to fix?
  13. Andreas Kienast commented on patch set 5 10/02/18, 06:15

    > Patch Set 5: > > that was me. but maybe @andy can you explain what this patch is going to fix? Will try my best
  14. Andreas Kienast uploaded patch set 6 10/02/18, 06:43

  15. TYPO3com voted on patch set 6 V +1 10/02/18, 06:57 Completed build in 14m 04s on Tue, 2 Oct, 08:57 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29258

  16. Andreas Wolf commented on patch set 6 10/02/18, 07:35

    Some nits picked…
    over
    shouldn't there be blank lines around each list item? Or at least before and after the list?

    EntityPointerLink.php:32

    "ancestor" implies this is always a parent–child relation, and we're traversing it bottom–up, correct?

    EntityPointerLink.php:60

    this can never actually return null, or?

    RecordState.php:24

    this could be an enumeration
  17. Andreas Kienast commented on patch set 6 10/02/18, 07:45

    EntityPointerLink.php:32 Reply

    There's not always a relation, but if there is one, then you're right

    EntityPointerLink.php:60 Reply

    Ack
  18. Andreas Kienast uploaded patch set 7 10/02/18, 07:50

  19. TYPO3com voted on patch set 7 V +1 10/02/18, 08:01 Completed build in 11m 15s on Tue, 2 Oct, 10:01 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29264

  20. Andreas Wolf commented on patch set 7 10/06/18, 08:53

    EntityPointerLink.php:32 Reply

    I asked that because if it is so, we should probably document that in the class comment, to make this clear. Otherwise it's not really clear IMO…

    EntityPointerLink.php:60 Reply

    thanks for the fix :)
  21. Andreas Wolf voted on patch set 7 CR +1 10/06/18, 08:53

  22. Daniel Goerz voted on patch set 7 V +1 10/25/18, 11:22

  23. Susi Moog voted on patch set 7 CR +1 10/25/18, 11:39

  24. Oliver Hader voted on patch set 7 V +2 CR +2 10/27/18, 20:35

  25. Oliver Hader merged patch set 8 10/27/18, 20:37