58234[BUGFIX] Saving of mixed InstallTool values
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1114
-
Guido Schmechel uploaded patch set 1 09/08/18, 21:32
-
TYPO3com voted on patch set 1 V +1 09/08/18, 21:39 Completed build in 07m 27s on Sat, 8 Sep, 11:39 PM Test Summary: 59428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2933
-
Guido Schmechel uploaded patch set 2 09/08/18, 21:50
-
Guido Schmechel updated the commit message in patch set 3 09/08/18, 21:52
-
TYPO3com voted on patch set 2 V +1 09/08/18, 21:58 Completed build in 08m 01s on Sat, 8 Sep, 11:58 PM Test Summary: 59428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2934
-
TYPO3com voted on patch set 3 V +1 09/08/18, 22:00 Completed build in 07m 13s on Sun, 9 Sep, 12:00 AM Test Summary: 59428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2935
-
Ioulia Kondratovitch voted on patch set 3 V +1 12/05/18, 18:37
-
Oliver Klee commented on patch set 3 12/05/18, 19:23
The master is not affected?AllConfiguration.php:140Was it already an array before? Or do we also need to adapt the caller(s)?AllConfiguration.php:213The types are missing in the @param annotations.AllConfiguration.php:217Any reason to have no type declarations for the parameters? -
Oliver Klee commented on patch set 3 12/05/18, 19:24
Reply
I've just read the ticket. This indeed is 8.7 only. -
Mona Muzaffar commented on patch set 3 CR -1 12/07/18, 10:42
One can now set the value. But when you only set one value, for example only set a value for proxy, the other two are automatically added with an empty string as a value. (if they don't already exist in the LocalConf already) Only the configuration which is explicitly set, should be added to the LocalConf -
Mona Muzaffar voted on patch set 3 V -1 CR 0 12/07/18, 10:43
-
Guido Schmechel uploaded patch set 4 12/07/18, 23:28
-
Guido Schmechel uploaded patch set 5 12/07/18, 23:36
-
Guido Schmechel abandoned the change 05/29/19, 08:49
No more support for bugfixes