Review main Merged

58235[BUGFIX] Avoid excluding fields in copyToLanguage

Oliver Hader CR +2 V +2 Easy +3 −15 updated 10/27/18, 14:53

Commit message

Given that a TCA column is using 'l10n_mode' => 'exclude' and creating
a "free localization" of that record using DataHandler's copyToLanguage
command, the according field stays empty in the created localization.

The expected behavior is that the accordings field is still duplicated
once on creating the duplicate for a particular language. Title prefix
"[Translate to <language>:]" is expected to be missing here since it
is the result of a copy command instead of a localize command.

Review

  • Code review CR +2
    • Benni Mack +2
    • Jürgen Heym +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1216

  1. Oliver Hader uploaded patch set 1 09/09/18, 09:18

  2. Oliver Hader commented on patch set 1 CR -1 09/09/18, 09:20

    Needs some more tests...
  3. TYPO3com voted on patch set 1 V +1 09/09/18, 09:29 Completed build in 10m 20s on Sun, 9 Sep, 11:29 AM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27913

  4. Frans Saris commented on patch set 1 09/09/18, 14:00

    Shouldn't this also be targeted for 8.7?
  5. Oliver Hader commented on patch set 1 09/09/18, 17:43

    @Franks: Currently it's work-in-progress... I'm not sure whether this should go to 8.7 as well. I'm puzzled, that I remove a part in DataHandler and tests are still green...
  6. Oliver Hader commented on patch set 1 09/09/18, 17:44

    "Frans" of course, sorry for the typo
  7. Oliver Hader rebased onto patch set 2 09/10/18, 21:12

  8. TYPO3com voted on patch set 2 V -1 09/10/18, 21:21 Completed build in 09m 19s on Mon, 10 Sep, 11:21 PM Test Summary: 3 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27962

  9. Oliver Hader rebased onto patch set 3 10/26/18, 15:20

  10. TYPO3com voted on patch set 3 V -1 10/26/18, 15:50 Completed build in 18m 07s on Fri, 26 Oct, 05:50 PM Test Summary: 3 of 38179 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29620

  11. Oliver Hader uploaded patch set 4 10/26/18, 17:22

  12. TYPO3com voted on patch set 4 V +1 10/26/18, 17:34 Completed build in 11m 52s on Fri, 26 Oct, 07:34 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29624

  13. Jürgen Heym voted on patch set 4 CR +1 10/27/18, 14:18

  14. Susi Moog voted on patch set 4 V +1 CR +1 10/27/18, 14:24

  15. Benni Mack voted on patch set 4 V +2 CR +2 10/27/18, 14:53

  16. Benni Mack merged patch set 5 10/27/18, 14:53