Review main Merged

58238[BUGFIX] Display correct original state when invertStateDisplay is true

Jigal van Hemert CR +2 V +2 Normal +67 −1 updated 09/30/18, 15:10

Commit message

In the fieldWizard defaultLanguageDifferences the opposite value must be
displayed if invertStateDisplay is active in fields of type "check".

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Jan Helke +1
    • Frans Saris +1
  • Verified V +2
    • Stefan Neufeind +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Jigal van Hemert uploaded patch set 1 09/09/18, 11:01

  2. TYPO3com voted on patch set 1 V +1 09/09/18, 11:13 Completed build in 11m 30s on Sun, 9 Sep, 01:13 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27915

  3. Frans Saris commented on patch set 1 09/09/18, 14:02

    Can we provide some tests for this?
  4. Christian Kuhn commented on patch set 1 09/10/18, 07:40

    BackendUtility.php:2201

    this looks fishy since the body is executed if $theColConf['items'] is no array, too.
  5. Jigal van Hemert uploaded patch set 2 09/11/18, 18:35

  6. TYPO3com voted on patch set 2 V +1 09/11/18, 18:43 Completed build in 08m 22s on Tue, 11 Sep, 08:43 PM Test Summary: 35875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27975

  7. Jigal van Hemert uploaded patch set 3 09/11/18, 18:53

  8. Jigal van Hemert commented on patch set 1 09/11/18, 18:57

    > Can we provide some tests for this? Like this?

    BackendUtility.php:2201 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 09/11/18, 19:02 Completed build in 08m 37s on Tue, 11 Sep, 09:02 PM Test Summary: 35875 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27976

  10. Frans Saris voted on patch set 3 CR +1 09/12/18, 05:31

  11. Jan Helke voted on patch set 3 V +1 CR +1 09/28/18, 09:50

  12. Tymoteusz Motylewski commented on patch set 3 09/28/18, 10:03

    can you provide testing instruction?
  13. Jan Helke commented on patch set 3 09/28/18, 10:24

    Pick a translated content on a translated page. On the access tab You have the visibility switch. Below that is the value of the default language object. Given the default element is not hidden it reads "No". That's the bug. Now apply the patch and the "No" turns miraculously into "Yes". If only some other "No"s would be so easy to switch. :-)
  14. Stefan Neufeind voted on patch set 3 V +1 CR +1 09/30/18, 14:57

  15. Stefan Neufeind voted on patch set 3 V +2 CR +2 09/30/18, 15:10

  16. Stefan Neufeind merged patch set 4 09/30/18, 15:10