Review main Merged

58243[BUGFIX] Allow recycler page in rootline in BE

Georg Ringer CR +2 V +2 Easy +11 −9 updated 09/13/18, 04:24

Commit message

The recycler doktype should be allowed in rootline in BE.

Review

  • Code review CR +2
    • Benni Mack +2
    • Joerg Kummer +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Georg Ringer uploaded patch set 1 09/10/18, 06:46

  2. TYPO3com voted on patch set 1 V +1 09/10/18, 06:58 Completed build in 11m 58s on Mon, 10 Sep, 08:58 AM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27930

  3. Joerg Kummer voted on patch set 1 V +1 CR +1 09/10/18, 07:06

  4. Benni Mack commented on patch set 1 CR -1 09/10/18, 14:28

    This way, the rootline cache writes the same entry when set up with BE and FE contexts, so this needs to be considered as well.
  5. Georg Ringer commented on patch set 1 09/10/18, 15:39

    does this mean that the current implementation is also faulty because query constraints are currently different for BE & FE?
  6. Georg Ringer uploaded patch set 2 09/10/18, 15:50

  7. TYPO3com voted on patch set 2 V -1 09/10/18, 16:03 Completed build in 13m 03s on Mon, 10 Sep, 06:03 PM Test Summary: 3 of 36211 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27953

  8. Georg Ringer uploaded patch set 3 09/10/18, 17:02

  9. TYPO3com voted on patch set 3 V +1 09/10/18, 17:10 Completed build in 08m 31s on Mon, 10 Sep, 07:10 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27956

  10. Joerg Kummer voted on patch set 3 V +1 CR +1 09/10/18, 17:22

  11. Wouter Wolters voted on patch set 3 CR +1 09/10/18, 18:49

  12. Susi Moog commented on patch set 3 CR -1 09/12/18, 15:32

    talking to benni about this currently.
  13. Susi Moog uploaded patch set 4 09/12/18, 16:17

  14. Susi Moog commented on patch set 4 09/12/18, 16:18

    After a talk with Benni we came up with a different solution: Rootline utility should not know anything about TYPO3 modes at all, instead, the access to pages in a recycler should be blocked in frontend explicitly - and we actually already have a place for it ;) This behaviour is now more in line to that of version 8, too.
  15. TYPO3com voted on patch set 4 V +1 09/12/18, 16:26 Completed build in 09m 25s on Wed, 12 Sep, 06:26 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27994

  16. Joerg Kummer voted on patch set 4 V +1 CR +1 09/12/18, 17:17

  17. Wouter Wolters voted on patch set 4 CR +1 09/12/18, 17:38

  18. Benni Mack voted on patch set 4 V +2 CR +2 09/13/18, 04:24

  19. Benni Mack merged patch set 5 09/13/18, 04:24