Review main Merged

58249[TASK] Deprecate BaseScriptClass and AbstractFunctionModule

Christian Kuhn CR +2 V +2 Normal +86 −0 updated 09/12/18, 18:12

Commit message

With latest refactorings, the good old backend module classes
BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule
(t3lib_extobjbase) are finally unused.
These spaghetti classes have been a hindrance to refactor
modules that used them for a long time already due to their
hard to follow code flow, bad method namings, global variable
usages and having everything declared public.
It's time to get rid of them to unlock refactoring of controllers
and allow dropping of various global variables in v10.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1214

  1. Christian Kuhn uploaded patch set 1 09/10/18, 21:56

  2. TYPO3com voted on patch set 1 V +1 09/10/18, 22:04 Completed build in 08m 07s on Tue, 11 Sep, 12:04 AM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27963

  3. Benni Mack voted on patch set 1 CR +1 09/11/18, 04:47

  4. Wouter Wolters voted on patch set 1 CR +1 09/11/18, 06:30

  5. Mathias Brodala commented on patch set 1 09/11/18, 06:48

    Deprecation-86225-ClassesBaseScriptClassAndAbstractFunctionModule.rst:48

    Just from reading this it is a bit unclear what needs to be done. Are the two methods init() and main() still required to be public to extend Page/Info and Page/Template or can other methods (= entrypoints) be registered instead?
  6. Christian Kuhn uploaded patch set 2 09/11/18, 08:42

  7. TYPO3com voted on patch set 2 V +1 09/11/18, 08:52 Completed build in 09m 38s on Tue, 11 Sep, 10:52 AM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27969

  8. Wouter Wolters voted on patch set 2 V +1 CR +1 09/12/18, 16:59

  9. Anja Leichsenring commented on patch set 2 V -1 CR +2 09/12/18, 17:57

    there are still usages for the classes. I push an update
  10. Anja Leichsenring wrote 09/12/18, 17:57

    Removed Code-Review+2 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  11. Anja Leichsenring wrote 09/12/18, 18:08

    Removed Verified-1 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  12. Anja Leichsenring commented on patch set 2 09/12/18, 18:08

    well, I don't. Ready for review.
  13. Georg Ringer voted on patch set 2 V +2 CR +2 09/12/18, 18:12

  14. Georg Ringer merged patch set 3 09/12/18, 18:12