58256[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Markus Klein +1
- Helmut Hummel +1
-
Verified V +2
- Georg Ringer +2
- Markus Klein +1
- Helmut Hummel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 78
-
Tymoteusz Motylewski uploaded patch set 1 09/12/18, 15:14
-
TYPO3com voted on patch set 1 V +1 09/12/18, 15:24 Completed build in 10m 20s on Wed, 12 Sep, 05:24 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27992
-
Helmut Hummel voted on patch set 1 V +1 CR +1 09/12/18, 15:33
-
Markus Klein commented on patch set 1 V +1 CR +1 09/12/18, 15:53
Did you check whether the applicationcontext is never used? I couldn't find any usages -
Georg Ringer voted on patch set 1 V +2 CR +2 09/12/18, 18:14
-
Georg Ringer merged patch set 2 09/12/18, 18:14
-
Benjamin Franzke commented on patch set 2 09/12/18, 23:17
As Markus said, ApplicationContext is'nt used in the container (right now), but it was added in preparation for future usage in https://review.typo3.org/c/55773/ That (initial idea) broke with https://review.typo3.org/c/57816/ were the code was refactored. Therefore it would have been better to replace that line with something like: ApplicationContext::class => Environment::getContext() Anyway, as it's unused for now, it can be added back later, when it's actually needed. -
Tymoteusz Motylewski commented on patch set 2 09/13/18, 11:34
Thanks for the clarification Benjamin. Lets re-add it once it's needed.