58262[TASK] Make hreflang links absolute
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Kevin Appelt +1
- Jörg Bösche +1
-
Verified V +2
- Jigal van Hemert +2
- Kevin Appelt +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1923
-
Richard Haeser uploaded patch set 1 09/12/18, 20:51
-
TYPO3com voted on patch set 1 V +1 09/12/18, 21:01 Completed build in 09m 24s on Wed, 12 Sep, 11:01 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28016
-
Markus Klein commented on patch set 1 09/12/18, 21:34
isn't this rather a bugfix? -
Richard Haeser commented on patch set 1 09/12/18, 21:36
Reply
Well it is not wrong to have relative url's, but it is best practice to have absolute url's. So technically it is not a bug. But yeah... Doesn't matter to me how we call it ;-) -
Markus Klein commented on patch set 1 09/13/18, 06:59
Reply
Fine then. -
Richard Haeser uploaded patch set 2 09/13/18, 18:44
-
TYPO3com voted on patch set 2 V +1 09/13/18, 18:53 Completed build in 09m 28s on Thu, 13 Sep, 08:53 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28053
-
Susi Moog voted on patch set 2 CR +1 09/13/18, 18:55
-
Richard Haeser commented on patch set 2 CR -1 09/13/18, 18:56
HreflangGenerator.php:77Ah this is not needed for this patch -
Richard Haeser commented on patch set 2 09/13/18, 18:56
On it -
Richard Haeser uploaded patch set 3 09/13/18, 19:20
-
TYPO3com voted on patch set 3 V +1 09/13/18, 19:30 Completed build in 09m 18s on Thu, 13 Sep, 09:30 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28057
-
Richard Haeser uploaded patch set 4 09/13/18, 19:34
-
Kevin Appelt voted on patch set 4 V +1 CR +1 09/13/18, 19:41
-
TYPO3com voted on patch set 4 V +1 09/13/18, 19:42 Completed build in 08m 25s on Thu, 13 Sep, 09:42 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28058
-
Jörg Bösche voted on patch set 4 CR +1 09/13/18, 21:15
-
Jigal van Hemert voted on patch set 4 V +2 CR +2 09/13/18, 22:34
-
Jigal van Hemert merged patch set 5 09/13/18, 22:34
-
Guido Schmechel commented on patch set 5 09/14/18, 06:34
HreflangGenerator.php:84Maybe it it safer to check via parse_url and check "scheme"? -
Jigal van Hemert commented on patch set 5 09/14/18, 06:43
HreflangGenerator.php:84ReplyCan you explain how that is safer? parse_url is certainly slower and requires more complex processing inside parse_url. -
Guido Schmechel commented on patch set 5 09/14/18, 06:54
> Patch Set 5: > > (1 comment) "Safer" because there is only a check for the schemeHreflangGenerator.php:84Reply"Safer" because it checks only the scheme and not the complete url -
Richard Haeser commented on patch set 5 09/14/18, 07:39
HreflangGenerator.php:84ReplyOk, I get it indeed. If someone uses httpismydomain.com (without scheme) this comparison will return true. strpos is on my local machine 6 times faster as parse_url, but this can return false positives indeed. -
Richard Haeser commented on patch set 5 09/14/18, 07:54
HreflangGenerator.php:84Reply UnresolvedAh this is not a problem. The site management will prefix a domain with // if no scheme is given so this comparison is ok I guess.