Review main Merged

58263[BUGFIX] Omit checkbox for unselectable tree items

Sebastian Michaelsen CR +2 V +2 Easy +2 −0 updated 09/17/18, 15:07

Commit message

TCA select fields with renderType = 'selectTree' have the option
treeConfig.appearance.nonSelectableLevels, which doesn't seem
to work anymore since TYPO3 v7. The items are correctly flagged
with node.selectable = false in PHP but the JavaScript doesn't
check for that property.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Joerg Kummer +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Sebastian Michaelsen uploaded patch set 1 09/13/18, 09:51

  2. Sebastian Michaelsen commented on patch set 1 09/13/18, 09:54

    How to test: 1. Create a few sys_categories with at least 3 hierarchy levels 2. Add to your PageTS: TCEFORM.pages.categories.config.treeConfig.appearance.nonSelectableLevels = 0,1 Check the categories field in page record backend form.
  3. TYPO3com voted on patch set 1 V +1 09/13/18, 10:00 Completed build in 08m 10s on Thu, 13 Sep, 12:00 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28020

  4. Sebastian Michaelsen updated the commit message in patch set 2 09/13/18, 10:03

  5. TYPO3com voted on patch set 2 V +1 09/13/18, 10:10 Completed build in 07m 11s on Thu, 13 Sep, 12:10 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28021

  6. Joerg Kummer voted on patch set 2 V +1 CR +1 09/13/18, 11:22

  7. Andreas Kienast voted on patch set 2 CR +1 09/14/18, 08:42

  8. Tymoteusz Motylewski commented on patch set 2 09/14/18, 14:55

    I remember that I have manually tested this setting an it worked when I've introduced svg tree in v8. So it would be nice to know how was it solved back then. In general this change looks quite ok.
  9. Tymoteusz Motylewski voted on patch set 2 CR +1 09/17/18, 07:34

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 09/17/18, 14:58

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 09/17/18, 15:07

  12. Christian Kuhn merged patch set 3 09/17/18, 15:07