Review main Merged

58266[BUGFIX] Evaluate config.defaultGetVars in middleware

Benni Mack CR +2 V +2 Easy +15 −0 updated 09/13/18, 13:05

Commit message

The config.defaultGetVars is executed and $_GET is modified,
but not the middleware where this method is called.

In order to also modify the middleware's request object, the
option config.defaultGetVars is also evaluted again in the PSR-15
middleware.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Daniel Sattler +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 09/13/18, 11:41

  2. Benni Mack updated the commit message in patch set 2 09/13/18, 11:45

  3. TYPO3com voted on patch set 1 V +1 09/13/18, 11:52 Completed build in 10m 32s on Thu, 13 Sep, 01:52 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28026

  4. TYPO3com voted on patch set 2 V +1 09/13/18, 11:54 Completed build in 09m 31s on Thu, 13 Sep, 01:54 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28027

  5. Daniel Sattler voted on patch set 2 V +1 CR +1 09/13/18, 11:57

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 09/13/18, 12:57

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 09/13/18, 13:05

  8. Wouter Wolters merged patch set 3 09/13/18, 13:05