Review main Merged

58267[BUGFIX] Use correct language in l18n_cfg checks

Daniel Goerz CR +2 V +2 Normal +88 −59 updated 09/13/18, 20:00

Commit message

The check for pages.l18n_cfg is wrong now, as this is
always done against pages.sys_language_uid=0 records (as
"resolvePage" is called right before).

So, these if-statements have to go further south.

On top, the getPageOverlay call needs to be done - on top.

resolvePage -> get default language of page
getPageOverlay -> put the wanted translation on top

A fix for pages.alias has to be in place, as DataHandler
cannot handle pages.alias yet.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1118

  1. Daniel Goerz uploaded patch set 1 09/13/18, 13:15

  2. Daniel Goerz wrote 09/13/18, 13:19

    Assignee added: Benni Mack <benni@typo3.org>
  3. TYPO3com voted on patch set 1 V -1 09/13/18, 13:24 Completed build in 08m 44s on Thu, 13 Sep, 03:24 PM Test Summary: 138 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28030

  4. Benni Mack uploaded patch set 2 09/13/18, 14:31

  5. TYPO3com voted on patch set 2 V -1 09/13/18, 14:42 Completed build in 11m 00s on Thu, 13 Sep, 04:42 PM Test Summary: 18 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28037

  6. Benni Mack uploaded patch set 3 09/13/18, 15:31

  7. TYPO3com voted on patch set 3 V -1 09/13/18, 15:43 Completed build in 11m 26s on Thu, 13 Sep, 05:43 PM Test Summary: 18 of 36217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28045

  8. Benni Mack uploaded patch set 4 09/13/18, 18:37

  9. TYPO3com voted on patch set 4 V +1 09/13/18, 18:47 Completed build in 09m 50s on Thu, 13 Sep, 08:47 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28052

  10. Benni Mack uploaded patch set 5 09/13/18, 19:02

  11. TYPO3com voted on patch set 5 V +1 09/13/18, 19:12 Completed build in 09m 44s on Thu, 13 Sep, 09:12 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28055

  12. Oliver Hader uploaded patch set 6 09/13/18, 19:36

  13. TYPO3com voted on patch set 6 V -1 09/13/18, 19:46 Completed build in 10m 37s on Thu, 13 Sep, 09:46 PM Test Summary: 6 of 36262 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28059

  14. Oliver Hader uploaded patch set 7 09/13/18, 19:47

  15. TYPO3com voted on patch set 7 V +1 09/13/18, 19:55 Completed build in 08m 04s on Thu, 13 Sep, 09:55 PM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28060

  16. Benni Mack voted on patch set 7 V +1 CR +1 09/13/18, 19:59

  17. Oliver Hader voted on patch set 7 V +2 CR +2 09/13/18, 20:00

  18. Oliver Hader merged patch set 8 09/13/18, 20:00