Review main Merged

58273[BUGFIX] Make JavaScript of SlugElement a real independent instance

Andreas Kienast CR +2 V +2 Hard +210 −152 updated 09/14/18, 09:47

Commit message

The JavaScript for the SlugElement is partially designed to be a
independent instance for each slug field. However, this does not work for
mass editing the slug fields, as the `initialize()` method is always
called on the same instance.

This patch does multiple things:

- The JavaScript is converted to a TypeScript basis, which allows better
  handling of each instance
- The "Regenerate slug" button is disabled in case the "feeder" fields
  are not available to avoid getting bogus values

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 811

  1. Andreas Kienast uploaded patch set 1 09/14/18, 08:17

  2. Andreas Kienast uploaded patch set 2 09/14/18, 08:19

  3. Andreas Kienast uploaded patch set 3 09/14/18, 08:27

  4. TYPO3com voted on patch set 1 V +1 09/14/18, 08:27 Completed build in 10m 45s on Fri, 14 Sep, 10:27 AM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28072

  5. TYPO3com voted on patch set 2 V +1 09/14/18, 08:28 Completed build in 09m 41s on Fri, 14 Sep, 10:28 AM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28073

  6. TYPO3com voted on patch set 3 V +1 09/14/18, 08:37 Completed build in 10m 14s on Fri, 14 Sep, 10:37 AM Test Summary: 35914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28074

  7. Christian Kuhn commented on patch set 3 CR -1 09/14/18, 09:45

    on it.
  8. Christian Kuhn voted on patch set 3 V +1 CR +1 09/14/18, 09:47

  9. Frank Nägler voted on patch set 3 V +1 CR +1 09/14/18, 09:47

  10. Frank Nägler voted on patch set 3 V +2 CR +2 09/14/18, 09:47

  11. Frank Nägler merged patch set 4 09/14/18, 09:47