Review main Merged

58285[BUGFIX] Fix fatal in SchedulerModuleController on some DB drivers

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 09/15/18, 17:02

Commit message

Some DB drivers like pdo_mysql and our postgres flavor return
values from DB always as string. Classes with enabled strict_types
then tend to fail if those values that should be integers but are
strings are fed to functions that accept integers only. The patch
fixes two places in SchedulerModuleController where a db value
is directly sent to date(), which needs an int as second argument.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Christian Kuhn uploaded patch set 1 09/15/18, 13:57

  2. Christian Kuhn commented on patch set 1 09/15/18, 13:59

    test: have a task that has a 'last execution' and / or 'next execution' date set up (eg. the sleep task), then use db driver 'pdo_mysql' instead of 'mysqli' in LocalConfiguration -> crash.
  3. Christian Kuhn updated the commit message in patch set 2 09/15/18, 14:00

  4. TYPO3com voted on patch set 1 V +1 09/15/18, 14:07 Completed build in 10m 08s on Sat, 15 Sep, 04:07 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28125

  5. TYPO3com voted on patch set 2 V +1 09/15/18, 14:11 Completed build in 10m 08s on Sat, 15 Sep, 04:11 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28126

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 09/15/18, 15:54

  7. Andreas Kienast rebased onto patch set 3 09/15/18, 16:02

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 09/15/18, 16:02

  9. TYPO3com voted on patch set 3 V +1 09/15/18, 16:13 Completed build in 11m 00s on Sat, 15 Sep, 06:13 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28132

  10. Georg Ringer voted on patch set 3 V +2 CR +2 09/15/18, 17:02

  11. Georg Ringer merged patch set 4 09/15/18, 17:02