58289[TASK] Suppress db call for rootline with uid 0
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2430
Show 35 earlier messages
-
Christian Kuhn uploaded patch set 1 09/16/18, 07:44
-
Stephan Großberndt updated the commit message in patch set 2 09/16/18, 07:54
-
Stephan Großberndt voted on patch set 2 CR +1 09/16/18, 07:54
-
TYPO3com voted on patch set 1 V +1 09/16/18, 07:57 Completed build in 13m 34s on Sun, 16 Sep, 09:57 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28148
-
TYPO3com voted on patch set 2 V +1 09/16/18, 08:06 Completed build in 11m 35s on Sun, 16 Sep, 10:06 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28150
-
Markus Klein voted on patch set 2 V +1 CR +1 09/16/18, 08:26
-
Frans Saris voted on patch set 2 CR +1 09/16/18, 09:17
-
Jörg Bösche voted on patch set 2 CR +1 09/16/18, 09:20
-
Anja Leichsenring uploaded patch set 3 09/16/18, 09:29
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 09/16/18, 09:31
-
TYPO3com voted on patch set 3 V +1 09/16/18, 09:38 Completed build in 09m 21s on Sun, 16 Sep, 11:38 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28161
-
Wouter Wolters voted on patch set 3 CR +1 09/16/18, 10:11
-
Stephan Großberndt voted on patch set 3 CR +1 09/16/18, 11:07
-
Oliver Klee commented on patch set 3 09/16/18, 11:52
-
Anja Leichsenring commented on patch set 3 09/16/18, 11:56
> Patch Set 3: > > (1 comment) site / pseudosite is returned in the function, not the rootline. This is only part of the procession. -
Andreas Kienast commented on patch set 3 09/16/18, 13:30
PseudoSiteFinder.php:168ReplyI wonder whether this code is necessary at all. In my tests, `this->pseudoSites[$pageId]` was always set with a NullSite, which will lead to the upper return. -
Andreas Kienast commented on patch set 3 09/16/18, 13:31
PseudoSiteFinder.php:168Reply`$this->pseudoSites[0]` of course... -
Christian Kuhn commented on patch set 3 CR -2 09/16/18, 13:33
PseudoSiteFinder.php:168Replyok. please revert the change in this file again. -
Christian Kuhn uploaded patch set 4 09/16/18, 13:35
-
Christian Kuhn voted on patch set 4 CR 0 09/16/18, 13:36
-
TYPO3com voted on patch set 4 V +1 09/16/18, 13:45 Completed build in 09m 59s on Sun, 16 Sep, 03:45 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28178
-
Oliver Klee updated the commit message in patch set 5 09/16/18, 13:48
-
Christian Kuhn commented on patch set 5 09/16/18, 13:54
please stop writing uid in upper case letters, oliver. there is no point in doing so. -
Christian Kuhn updated the commit message in patch set 6 09/16/18, 13:55
-
TYPO3com voted on patch set 5 V +1 09/16/18, 13:59 Completed build in 10m 59s on Sun, 16 Sep, 03:59 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28179
-
TYPO3com commented on patch set 6 09/16/18, 14:02 Completed build in 07m 34s on Sun, 16 Sep, 04:02 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28180
-
Oliver Klee wrote 09/16/18, 14:29
Removed reviewer Oliver Klee. -
Andreas Kienast voted on patch set 6 V +1 CR +1 09/16/18, 14:36
-
Benni Mack voted on patch set 6 V +2 CR +2 09/16/18, 17:51
-
Benni Mack merged patch set 7 09/16/18, 17:51
PseudoSiteFinder.php:168