Review main Merged

58289[TASK] Suppress db call for rootline with uid 0

Christian Kuhn CR +2 V +2 Easy +8 −0 updated 09/16/18, 17:51

Commit message

Page uid 0 has no rootline by definition. The patch adds an
early return to RootlineUtility to suppress some cache->get()
calls. This happens in BE quite often. Additionally, the
SiteFinder does not query RootlineUtility for page uid 0 at
all to save a series of instance creations.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2430

Show 35 earlier messages
  1. Christian Kuhn uploaded patch set 1 09/16/18, 07:44

  2. Stephan Großberndt updated the commit message in patch set 2 09/16/18, 07:54

  3. Stephan Großberndt voted on patch set 2 CR +1 09/16/18, 07:54

  4. TYPO3com voted on patch set 1 V +1 09/16/18, 07:57 Completed build in 13m 34s on Sun, 16 Sep, 09:57 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28148

  5. TYPO3com voted on patch set 2 V +1 09/16/18, 08:06 Completed build in 11m 35s on Sun, 16 Sep, 10:06 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28150

  1. Markus Klein voted on patch set 2 V +1 CR +1 09/16/18, 08:26

  2. Frans Saris voted on patch set 2 CR +1 09/16/18, 09:17

  3. Jörg Bösche voted on patch set 2 CR +1 09/16/18, 09:20

  4. Anja Leichsenring uploaded patch set 3 09/16/18, 09:29

  5. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/16/18, 09:31

  6. TYPO3com voted on patch set 3 V +1 09/16/18, 09:38 Completed build in 09m 21s on Sun, 16 Sep, 11:38 AM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28161

  7. Wouter Wolters voted on patch set 3 CR +1 09/16/18, 10:11

  8. Stephan Großberndt voted on patch set 3 CR +1 09/16/18, 11:07

  9. Oliver Klee commented on patch set 3 09/16/18, 11:52

    PseudoSiteFinder.php:168

    Can't we then directly return [] here? And as for the $this->pseudoSites caching: Can't we move this guard clause above everything here?
  10. Anja Leichsenring commented on patch set 3 09/16/18, 11:56

    > Patch Set 3: > > (1 comment) site / pseudosite is returned in the function, not the rootline. This is only part of the procession.
  11. Andreas Kienast commented on patch set 3 09/16/18, 13:30

    PseudoSiteFinder.php:168 Reply

    I wonder whether this code is necessary at all. In my tests, `this->pseudoSites[$pageId]` was always set with a NullSite, which will lead to the upper return.
  12. Andreas Kienast commented on patch set 3 09/16/18, 13:31

    PseudoSiteFinder.php:168 Reply

    `$this->pseudoSites[0]` of course...
  13. Christian Kuhn commented on patch set 3 CR -2 09/16/18, 13:33

    PseudoSiteFinder.php:168 Reply

    ok. please revert the change in this file again.
  14. Christian Kuhn uploaded patch set 4 09/16/18, 13:35

  15. Christian Kuhn voted on patch set 4 CR 0 09/16/18, 13:36

  16. TYPO3com voted on patch set 4 V +1 09/16/18, 13:45 Completed build in 09m 59s on Sun, 16 Sep, 03:45 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28178

  17. Oliver Klee updated the commit message in patch set 5 09/16/18, 13:48

  18. Christian Kuhn commented on patch set 5 09/16/18, 13:54

    please stop writing uid in upper case letters, oliver. there is no point in doing so.
  19. Christian Kuhn updated the commit message in patch set 6 09/16/18, 13:55

  20. TYPO3com voted on patch set 5 V +1 09/16/18, 13:59 Completed build in 10m 59s on Sun, 16 Sep, 03:59 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28179

  21. TYPO3com commented on patch set 6 09/16/18, 14:02 Completed build in 07m 34s on Sun, 16 Sep, 04:02 PM Test Summary: 35905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28180

  22. Oliver Klee wrote 09/16/18, 14:29

    Removed reviewer Oliver Klee.
  23. Andreas Kienast voted on patch set 6 V +1 CR +1 09/16/18, 14:36

  24. Benni Mack voted on patch set 6 V +2 CR +2 09/16/18, 17:51

  25. Benni Mack merged patch set 7 09/16/18, 17:51