Review main Merged

58302[BUGFIX] Don’t do greedy merges in extension scanner

Andreas Kienast CR +2 V +2 Easy +3 −2 updated 09/18/18, 07:22

Commit message

The extension scanner merges all matches into an array. This is done in a
loop, which is pretty greedy as it impacts CPU and RAM.

Instead, it's possible to do a single array_merge() at the end of the
loop.

See this document for reference:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/17/18, 11:05

  2. TYPO3com voted on patch set 1 V +1 09/17/18, 11:16 Completed build in 11m 02s on Mon, 17 Sep, 01:16 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28221

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 09/17/18, 11:20

  4. Susi Moog voted on patch set 1 V +2 CR +2 09/18/18, 07:22

  5. Susi Moog merged patch set 2 09/18/18, 07:22

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/18/18, 07:22