Review main Merged

58303[BUGFIX] Trigger deprecation when using $TSFE->sys_language_*

Benni Mack CR +2 V +2 Easy +2 −2 updated 09/17/18, 12:41

Commit message

When deprecating TSFE->sys_language_mode and TSFE->sys_language_uid
it was forgotten (by myself) to set the visibility to protected.

This way, the deprecation layer (with compat calls) is never
used, and legacy code gets wrong results.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Mathias Brodala +1
    • Daniel Sattler +1
  • Verified V +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 09/17/18, 12:12

  2. Mathias Brodala updated the commit message in patch set 2 09/17/18, 12:15

  3. Mathias Brodala updated the commit message in patch set 3 09/17/18, 12:17

  4. Mathias Brodala voted on patch set 3 CR +1 09/17/18, 12:20

  5. TYPO3com voted on patch set 1 V +1 09/17/18, 12:23 Completed build in 10m 39s on Mon, 17 Sep, 02:23 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28223

  6. Daniel Goerz voted on patch set 3 V +1 CR +1 09/17/18, 12:25

  7. TYPO3com voted on patch set 2 V +1 09/17/18, 12:26 Completed build in 11m 31s on Mon, 17 Sep, 02:26 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28224

  8. TYPO3com voted on patch set 3 V +1 09/17/18, 12:30 Completed build in 12m 08s on Mon, 17 Sep, 02:30 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28225

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 09/17/18, 12:36

  10. Christian Kuhn merged patch set 4 09/17/18, 12:36

  11. Daniel Sattler voted on patch set 4 V +1 CR +1 09/17/18, 12:41