Review main Abandoned

58304[BUGFIX] Fix exception in IconFactory with deleted link record

TYPO3com CR 0 V 0 Easy +2 −1 updated 11/08/18, 20:55

Commit message

When a record link is deleted, the InputLinkElement was not checked if the
link had actually been deleted, and from that bug I could see that the
icon overlay did not even exist in DefaultConfiguration.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1014

  1. TYPO3com uploaded patch set 1 09/17/18, 12:57

  2. TYPO3com voted on patch set 1 V -1 09/17/18, 12:58 Completed build in 09s on Mon, 17 Sep, 02:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28228

  3. Oliver Klee commented on patch set 1 CR -1 09/17/18, 14:11

    This sentence seems to be cut of in the mi
  4. Vinícius Moura De Queiroz updated the commit message in patch set 2 09/18/18, 12:38

  5. TYPO3com voted on patch set 2 V -1 09/18/18, 12:38 Completed build in 12s on Tue, 18 Sep, 02:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28267

  6. Christian Kuhn uploaded patch set 3 09/18/18, 15:05

  7. Christian Kuhn commented on patch set 3 09/18/18, 15:06

    cgl fixed
  8. TYPO3com voted on patch set 3 V +1 09/18/18, 15:16 Completed build in 10m 26s on Tue, 18 Sep, 05:16 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28283

  9. Christian Kuhn commented on patch set 3 CR -1 09/18/18, 15:23

    hey. thanks for the patch. i'm not sure if we should do that, though: deleted=1 on a record in the backend means it's never shown. think of it as if the row has been dropped from the database. that is true for the entire backend, *except* for the recycler module. so you never see deleted records anywhere in the backend. for instance a record target in group/select/inline is also never shown. (do not confuse that with "hidden": hidden = not shown in FE, deleted = not shown in FE + BE). thus, we should not show links to deleted records if editing records via formEngine, either.
  10. Christian Kuhn commented on patch set 3 09/18/18, 15:30

    other than that, i don't really understand how / where an exception is thrown if the patch is not applied. could you elaborate a bit on that? maybe i'm doing something wrong.
  11. Oliver Klee wrote 09/18/18, 15:40

    Removed reviewer Oliver Klee.
  12. Vinícius Moura De Queiroz commented on patch set 3 09/21/18, 14:35

    > Patch Set 3: Code-Review-1 > > hey. thanks for the patch. > i'm not sure if we should do that, though: deleted=1 on a record in the backend means it's never shown. think of it as if the row has been dropped from the database. > that is true for the entire backend, *except* for the recycler module. > so you never see deleted records anywhere in the backend. for instance a record target in group/select/inline is also never shown. (do not confuse that with "hidden": hidden = not shown in FE, deleted = not shown in FE + BE). > thus, we should not show links to deleted records if editing records via formEngine, either. See my case - I was working on manual news component, which actually referred to real news via record link. when I deleted this real news, this link should be shown as deleted (with icon )by the manual notices component, but when the backend searched for the link to define its icon, it did not find and returned null, and from there it generated an exception in the overlay of IconFactory .
  13. Benni Mack commented on patch set 3 10/27/18, 21:01

    Hi Vinicius, thanks for your contribution. I tried reproducing this bug, and Daniel Goerz as well - we could not re-build steps to do this, so we need a better description (e.g. on the forge ticket) to cover this change. Please provide more input, otherwise I need to close this ticket with "cannot be reproduced". Thanks!
  14. Benni Mack abandoned the change 11/08/18, 20:55