Review main Merged

58309[TASK] Mark internal $TSFE properties as protected

Benni Mack CR +2 V +2 Normal +164 −11 updated 09/20/18, 03:23

Commit message

Due to some PHP4 legacy code, most properties in TSFE
were Public API. As some arguments are only used internally
within TSFE and _should_ only used internally, their
visibility has been modified to be protected, and the properties
themselves have also an additional @internal annotation.

For v9, accessing the properties from the outside will still
work but trigger a deprecation message.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Richard Haeser +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack uploaded patch set 1 09/18/18, 04:42

  2. TYPO3com voted on patch set 1 V +1 09/18/18, 04:52 Completed build in 09m 53s on Tue, 18 Sep, 06:52 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28252

  3. Wouter Wolters uploaded patch set 2 09/19/18, 19:20

  4. TYPO3com voted on patch set 2 V +1 09/19/18, 19:30 Completed build in 10m 34s on Wed, 19 Sep, 09:30 PM Test Summary: 35978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28396

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 09/19/18, 19:46

  6. Richard Haeser voted on patch set 2 CR +1 09/19/18, 21:18

  7. Georg Ringer voted on patch set 2 V +2 CR +2 09/20/18, 03:23

  8. Georg Ringer merged patch set 3 09/20/18, 03:23