Review main Merged

58312[BUGFIX] Fix casting in GalleryProcessing data processor

Thomas Deuling CR +2 V +2 Easy +1 −1 updated 09/18/18, 15:00

Commit message

Removing the integer casting, so that the cropVariant can also be a string identifier.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Jörg Bösche +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Thomas Deuling uploaded patch set 1 09/18/18, 09:43

  2. Mathias Brodala updated the commit message in patch set 2 09/18/18, 09:44

  3. Mathias Brodala voted on patch set 2 CR +1 09/18/18, 09:45

  4. TYPO3com voted on patch set 1 V +1 09/18/18, 09:55 Completed build in 11m 49s on Tue, 18 Sep, 11:55 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28262

  5. TYPO3com voted on patch set 2 V +1 09/18/18, 09:56 Completed build in 11m 11s on Tue, 18 Sep, 11:56 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28263

  6. Jörg Bösche voted on patch set 2 V +1 CR +1 09/18/18, 12:18

  7. Josef Glatz voted on patch set 2 CR +1 09/18/18, 12:47

  8. Oliver Klee voted on patch set 2 CR +1 09/18/18, 14:32

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 09/18/18, 14:59

  10. Christian Kuhn merged patch set 3 09/18/18, 15:00

  11. Christian Kuhn commented on patch set 3 09/18/18, 15:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6ef5f036a245eb844127375615102b27e18373a8