Review main Merged

58314[TASK] Harden system maintainer handling

Christian Kuhn CR +2 V +2 Normal +164 −3 updated 09/19/18, 13:55

Commit message

Better information handling and restrictions for non
system maintainer trying to change admin flag or password
of system maintainers.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1621

  1. Christian Kuhn uploaded patch set 1 09/18/18, 13:15

  2. Christian Kuhn uploaded patch set 2 09/18/18, 13:15

  3. TYPO3com voted on patch set 1 V -1 09/18/18, 13:15 Completed build in 19s on Tue, 18 Sep, 03:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28274

  4. TYPO3com voted on patch set 2 V +1 09/18/18, 13:25 Completed build in 09m 34s on Tue, 18 Sep, 03:25 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28275

  5. Christian Kuhn uploaded patch set 3 09/18/18, 13:37

  6. TYPO3com voted on patch set 3 V +1 09/18/18, 13:46 Completed build in 08m 49s on Tue, 18 Sep, 03:46 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28277

  7. Markus Klein commented on patch set 3 09/18/18, 18:54

    can you maybe add some more lines here what that means?

    DataHandler.php:1652

    we once had a patch where we changed all those in_array checks with only a few values to direct string comparisons as this is heaps faster an more memory efficient.
  8. Andreas Kienast commented on patch set 3 V +1 09/18/18, 18:56

    AdminIsSystemMaintainer.php:32 Unresolved

    Missing @throws

    AdminIsSystemMaintainer.php:71

    I wonder whether we can have an additional displayCond attached to the field "admin" and "password" that hides the fields in this specific case.
  9. Christian Kuhn commented on patch set 3 09/18/18, 19:08

    Reply

    kk

    AdminIsSystemMaintainer.php:71 Reply Unresolved

    i'd rather keep an information here: if the fields miss entirely, admins may be quite confused on why they are not shown and may waste time on looking for them.

    DataHandler.php:1652 Reply

    kk
  10. Christian Kuhn voted on patch set 3 CR -1 09/18/18, 19:18

  11. Christian Kuhn uploaded patch set 4 09/18/18, 19:23

  12. TYPO3com voted on patch set 4 V +1 09/18/18, 19:36 Completed build in 11m 53s on Tue, 18 Sep, 09:36 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28299

  13. Markus Klein commented on patch set 4 09/18/18, 20:14

    AdminIsSystemMaintainer.php:65

    don't get this message: if the target user is already a system maintainer there is no change to happen. The second part of the sentence "will become sys maint.." is wrong as the target user already is sys maint.
  14. Christian Kuhn commented on patch set 4 09/18/18, 20:23

    AdminIsSystemMaintainer.php:65 Reply

    it that case: user has been admin before AND set to sys maintainer in localConf. Later, admin flag has been removed, but uid NOT removed from LocalConf (and no, i do not want to make the DataHandler write LocalConfiguration on the fly to take care of that case). So, if anyone later makes an existing user admin again, the user may additionally become system maintainer if it is still in the list ... this message states that adding the admin flag again will also make the user a system maintainer.
  15. Markus Klein commented on patch set 5 09/18/18, 20:35

    Published edit on patch set 4.
  16. Markus Klein voted on patch set 5 CR +1 09/18/18, 20:36

  17. TYPO3com voted on patch set 5 V +1 09/18/18, 20:45 Completed build in 09m 53s on Tue, 18 Sep, 10:45 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28309

  18. Markus Klein voted on patch set 5 V +1 09/18/18, 21:29

  19. Andreas Kienast voted on patch set 5 V +1 09/19/18, 06:52

  20. Anja Leichsenring voted on patch set 5 V +2 CR +2 09/19/18, 13:55

  21. Anja Leichsenring merged patch set 6 09/19/18, 13:55