Review TYPO3_8-7 Merged

58316[BUGFIX] Make the "Stop preview" link clickable when previewing a page (workspaces)

Guillaume Germain CR +2 V +2 Easy +1 −1 updated 10/30/18, 20:52

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Guillaume Germain uploaded patch set 1 09/18/18, 14:29

  2. Guillaume Germain updated the commit message in patch set 2 09/18/18, 14:37

  3. TYPO3com voted on patch set 1 V +1 09/18/18, 14:37 Completed build in 07m 49s on Tue, 18 Sep, 04:37 PM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2945

  4. TYPO3com voted on patch set 2 V +1 09/18/18, 14:44 Completed build in 07m 27s on Tue, 18 Sep, 04:44 PM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2946

  5. Markus Klein commented on patch set 2 09/18/18, 18:50

    Hi Guillaume! Thanks for your patch. Is the bug also present in current master branch? If so it has to be fixed there first and the change will be backported to version 8 then.
    this is a bug description, but not a correct commit message title. Please readup the guidelines on good commit messages: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/CommitMessage.html
  6. Guillaume Germain updated the commit message in patch set 3 09/19/18, 07:10

  7. Guillaume Germain commented on patch set 3 09/19/18, 07:12

    > Patch Set 2: > > (1 comment) > > Hi Guillaume! Thanks for your patch. Is the bug also present in current master branch? > If so it has to be fixed there first and the change will be backported to version 8 then. Hi ! This bug is not present in master branch. See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php#L297

    Reply

    Done
  8. TYPO3com voted on patch set 3 V +1 09/19/18, 07:19 Completed build in 09m 21s on Wed, 19 Sep, 09:19 AM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2951

  9. Markus Klein voted on patch set 3 CR +1 09/19/18, 09:20

  10. Benni Mack voted on patch set 3 V +1 CR +2 10/29/18, 16:48

  11. Wouter Wolters voted on patch set 3 V +2 CR +2 10/30/18, 20:52

  12. Wouter Wolters merged patch set 4 10/30/18, 20:52