Review main Merged

58319[BUGFIX] Add stdWrap for SVG content object renderMode=inline

Josef Glatz CR +2 V +2 Easy +13 −0 updated 09/19/18, 18:14

Commit message

This patch adds stdWrap to the SVG content object if the
renderMode is set to inline.

This patch also adds the missing tsref configuration for the
EXT:t3editor auto completion.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Marco Bresch +1
    • Björn Jacob +1
    • Alexander Grein +1
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Marco Bresch +1
    • Thorsten Griebenow +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1618

  1. Josef Glatz uploaded patch set 1 09/18/18, 17:00

  2. Alexander Grein voted on patch set 1 CR +1 09/18/18, 17:09

  3. TYPO3com voted on patch set 1 V +1 09/18/18, 17:10 Completed build in 09m 26s on Tue, 18 Sep, 07:10 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28286

  4. Björn Jacob commented on patch set 1 09/19/18, 05:33

    Minor stuff.
    "adds"
    "also adds"
  5. Björn Jacob updated the commit message in patch set 2 09/19/18, 05:33

  6. TYPO3com voted on patch set 2 V +1 09/19/18, 05:45 Completed build in 11m 34s on Wed, 19 Sep, 07:45 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28323

  7. Wittkiel Gruppe wrote 09/19/18, 06:55

    Removed reviewer Wittkiel Gruppe.
  8. Thorsten Griebenow voted on patch set 2 V +1 09/19/18, 08:30

  9. Marco Bresch voted on patch set 2 CR +1 09/19/18, 08:31

  10. Marco Bresch commented on patch set 2 V +1 09/19/18, 08:36

    Yes, this patch works fine. Tested renderMode = inline with and without stdWrap. Both works as expected.
  11. Marco Bresch commented on patch set 2 09/19/18, 08:45

    Code completion in TypoScript editor works fine to for stdWrap! :-)
  12. Alexander Grein voted on patch set 2 CR +1 09/19/18, 08:59

  13. Björn Jacob voted on patch set 2 CR +1 09/19/18, 09:03

  14. Andreas Kienast voted on patch set 2 CR +1 09/19/18, 15:25

  15. Josef Glatz commented on patch set 2 09/19/18, 15:28

    Btw. you can test it without an svg file. Take the TypoScript from https://pastebin.com/raw/Ca0fnrNg to test it
  16. Richard Haeser voted on patch set 2 CR +1 09/19/18, 17:33

  17. Georg Ringer voted on patch set 2 V +2 CR +2 09/19/18, 18:14

  18. Georg Ringer merged patch set 3 09/19/18, 18:14