58319[BUGFIX] Add stdWrap for SVG content object renderMode=inline
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Marco Bresch +1
- Björn Jacob +1
- Alexander Grein +1
- Richard Haeser +1
- Andreas Kienast +1
-
Verified V +2
- Georg Ringer +2
- Marco Bresch +1
- Thorsten Griebenow +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1618
-
Josef Glatz uploaded patch set 1 09/18/18, 17:00
-
Alexander Grein voted on patch set 1 CR +1 09/18/18, 17:09
-
TYPO3com voted on patch set 1 V +1 09/18/18, 17:10 Completed build in 09m 26s on Tue, 18 Sep, 07:10 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28286
-
Björn Jacob updated the commit message in patch set 2 09/19/18, 05:33
-
TYPO3com voted on patch set 2 V +1 09/19/18, 05:45 Completed build in 11m 34s on Wed, 19 Sep, 07:45 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28323
-
Wittkiel Gruppe wrote 09/19/18, 06:55
Removed reviewer Wittkiel Gruppe. -
Thorsten Griebenow voted on patch set 2 V +1 09/19/18, 08:30
-
Marco Bresch voted on patch set 2 CR +1 09/19/18, 08:31
-
Marco Bresch commented on patch set 2 V +1 09/19/18, 08:36
Yes, this patch works fine. Tested renderMode = inline with and without stdWrap. Both works as expected. -
Marco Bresch commented on patch set 2 09/19/18, 08:45
Code completion in TypoScript editor works fine to for stdWrap! :-) -
Alexander Grein voted on patch set 2 CR +1 09/19/18, 08:59
-
Björn Jacob voted on patch set 2 CR +1 09/19/18, 09:03
-
Andreas Kienast voted on patch set 2 CR +1 09/19/18, 15:25
-
Josef Glatz commented on patch set 2 09/19/18, 15:28
Btw. you can test it without an svg file. Take the TypoScript from https://pastebin.com/raw/Ca0fnrNg to test it -
Richard Haeser voted on patch set 2 CR +1 09/19/18, 17:33
-
Georg Ringer voted on patch set 2 V +2 CR +2 09/19/18, 18:14
-
Georg Ringer merged patch set 3 09/19/18, 18:14