Review main Merged

58320[BUGFIX] Check $prefix in ActionTask

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 09/18/18, 20:09

Commit message

Check if the prefix is not an empty string to avoid a warning thrown by
strpos().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 89

  1. Andreas Kienast uploaded patch set 1 09/18/18, 18:43

  2. Markus Klein commented on patch set 1 V +1 CR +1 09/18/18, 18:46

    v8 too?
  3. Andreas Kienast commented on patch set 1 09/18/18, 18:49

    > Patch Set 1: Verified+1 Code-Review+1 > > v8 too? No, the code was merged in v9 only.
  4. TYPO3com voted on patch set 1 V +1 09/18/18, 18:51 Completed build in 07m 51s on Tue, 18 Sep, 08:51 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28292

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 09/18/18, 19:15

  6. Andreas Kienast commented on patch set 1 CR -1 09/18/18, 19:17

    Found another occurrence, will adjust the patch
  7. Andreas Kienast commented on patch set 1 CR 0 09/18/18, 19:28

    The code I found does not exist anymore.
  8. Christian Kuhn voted on patch set 1 V +2 CR +2 09/18/18, 20:09

  9. Christian Kuhn merged patch set 2 09/18/18, 20:09