Review main Merged

58322Revert "[TASK] Improve TranslateViewHelper compiling"

Christian Kuhn CR +2 V +2 Normal +29 −43 updated 09/19/18, 08:33

Commit message

The micro optimization introduced a bug, fixing the bug
would basically lead to the same code that is within
renderStatic() already. There is then no advantage in
having an inline compiled solution in comparison to a
static call to the class anymore. The initial patch and
its follow up are reverted.

This reverts commit e6f470ebd2ddac7f0c864fd7c18c3d12a9009c30.
This reverts commit 852ad1d9ad6f3bac4c977d2466d1875f9e632e01.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 09/18/18, 20:01

  2. TYPO3com voted on patch set 1 V +1 09/18/18, 20:10 Completed build in 08m 50s on Tue, 18 Sep, 10:10 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28304

  3. Susi Moog voted on patch set 1 V +1 CR +1 09/19/18, 07:37

  4. Frank Nägler voted on patch set 1 V +2 CR +2 09/19/18, 08:33

  5. Frank Nägler merged patch set 2 09/19/18, 08:33