Review main Merged

58324[TASK] Update CKEditor from 4.9.1 to 4.10.1

Josef Glatz CR +2 V +2 Nightmare +1373 −1264 updated 09/20/18, 18:15

Commit message

Update CKEditor to the lastest version that fixes a lot of bugs.

Release notes:
https://ckeditor.com/cke4/release-notes
https://ckeditor.com/cke4/release/CKEditor-4.9.2
https://ckeditor.com/cke4/release/CKEditor-4.10.0
https://ckeditor.com/cke4/release/CKEditor-4.10.1

@types/ckeditor has also been updated.

Following commands were used to update dependencies:
- yarn upgrade ckeditor@4.10.1 -E -D
- yarn upgrade @types/ckeditor@4.9.1 -E -D
(As there is no newer types definition, version 4.9.1 must
be used)

The following command was used to update the files
in EXT:rte_ckeditor:
- yarn build

Review

  • Code review CR +2
    • Markus Klein +2
    • Georg Ringer +1
  • Verified V +2
    • Markus Klein +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 119

Show 99 more files

Review log 79

  1. Josef Glatz uploaded patch set 1 09/18/18, 21:20

  2. TYPO3com voted on patch set 1 V +1 09/18/18, 21:30 Completed build in 09m 40s on Tue, 18 Sep, 11:30 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28313

  3. Josef Glatz updated the commit message in patch set 2 09/19/18, 05:28

  4. Josef Glatz commented on patch set 2 09/19/18, 05:29

    If you get a modified momentjs-timezone js file after running "yarn build": there's another ticket for it https://review.typo3.org/#/c/58325/
  5. TYPO3com voted on patch set 2 V +1 09/19/18, 05:37 Completed build in 08m 21s on Wed, 19 Sep, 07:37 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28322

  6. Josef Glatz commented on patch set 2 09/19/18, 11:38

    > If you get a modified momentjs-timezone js file after running "yarn > build": there's another ticket for it https://review.typo3.org/#/c/58325/ Mentioned side problem already fixed and merged (https://review.typo3.org/#/c/58325/)
  7. Georg Ringer voted on patch set 2 V +1 CR +1 09/20/18, 05:34

  8. Markus Klein voted on patch set 2 V +2 CR +2 09/20/18, 18:15

  9. Markus Klein merged patch set 3 09/20/18, 18:15