Review main Merged

58325[BUGFIX] Add correct moment-timezone file

Josef Glatz CR +2 V +2 Easy +1 −1 updated 09/19/18, 10:51

Commit message

This patch adds the correct moment-timezone javascript
file v0.5.20 which did not make it with the former patch
for #85223.

The following command was used:
- yarn upgrade moment-timezone@0.5.20

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 913

  1. Josef Glatz uploaded patch set 1 09/18/18, 21:43

  2. Markus Klein commented on patch set 1 09/18/18, 21:48

    shouldn't the lock file change as well with the upgrde?
  3. TYPO3com voted on patch set 1 V +1 09/18/18, 21:51 Completed build in 08m 05s on Tue, 18 Sep, 11:51 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28315

  4. Josef Glatz updated the commit message in patch set 2 09/19/18, 05:51

  5. TYPO3com voted on patch set 2 V +1 09/19/18, 06:01 Completed build in 10m 00s on Wed, 19 Sep, 08:01 AM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28324

  6. Josef Glatz commented on patch set 2 09/19/18, 06:31

    > shouldn't the lock file change as well with the upgrde? This is something what is strange indeed! Incidentally, this is the cause of this patch ¯\_(ツ)_/¯ Is it possible that the upstream repo force-pushed onto the already published version 0.5.20?
  7. Josef Glatz updated the commit message in patch set 3 09/19/18, 10:24

  8. Josef Glatz updated the commit message in patch set 4 09/19/18, 10:25

  9. Frank Nägler voted on patch set 4 V +1 CR +1 09/19/18, 10:26

  10. TYPO3com voted on patch set 3 V +1 09/19/18, 10:37 Completed build in 12m 42s on Wed, 19 Sep, 12:37 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28344

  11. TYPO3com voted on patch set 4 V +1 09/19/18, 10:41 Completed build in 11m 59s on Wed, 19 Sep, 12:41 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28345

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 09/19/18, 10:51

  13. Andreas Kienast merged patch set 5 09/19/18, 10:51