Review main Merged

58332[BUGFIX] Handle formEngine add wizard select in flex forms

Christian Kuhn CR +2 V +2 Easy +7 −1 updated 09/19/18, 14:00

Commit message

addRecord fieldControl fails for type=select fields
in flex forms in AddController since existing values
are not resolved to an array structure as it is done
for type=group fields. Handle that case.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 09/19/18, 10:36

  2. Christian Kuhn commented on patch set 1 09/19/18, 10:41

    test - identical in master & v8 with current styleguide git: without patch: edit (! not "new", this triggers other issues) tx_styleguide_select -> in flex -> selectMultipleSideBySide -> select_multiplesidebyside_1 -> click "+" field control button button -> enter some value -> save -> close -> boom.
  3. TYPO3com voted on patch set 1 V +1 09/19/18, 10:46 Completed build in 10m 27s on Wed, 19 Sep, 12:46 PM Test Summary: 35930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28346

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 09/19/18, 10:55

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/19/18, 13:59

  6. Anja Leichsenring merged patch set 2 09/19/18, 14:00

  7. Anja Leichsenring commented on patch set 2 09/19/18, 14:00

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8657c815b325cc792cb148d06861540cb1976774