Review main Merged

58337[BUGFIX] SiteResolver middleware must not care for non int id parameters

Anja Leichsenring CR +2 V +2 Normal +68 −9 updated 09/20/18, 07:33

Commit message

The FileList module uses the 'id' parameter to pass the directory around,
which makes the parameter a string in this case.
Site Resolver Middleware will no longer care for a parameter named 'id',
which is not strictly an integer.

Review

  • Code review CR +2
    • Susi Moog +2
    • Tobi Kretschmann +1
  • Verified V +2
    • Susi Moog +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2129

Show 24 earlier messages
  1. Anja Leichsenring uploaded patch set 1 09/19/18, 12:55

  2. TYPO3com voted on patch set 1 V -1 09/19/18, 13:04 Completed build in 09m 13s on Wed, 19 Sep, 03:04 PM Test Summary: 20 of 36281 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28368

  3. TYPO3com commented on patch set 1 09/19/18, 13:16 Completed build in 30m 14s on Wed, 19 Sep, 03:16 PM Test Summary: 20 of 36281 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28368

  4. Anja Leichsenring uploaded patch set 2 09/19/18, 13:20

  1. TYPO3com commented on patch set 1 09/19/18, 13:25 Completed build in 1h 00m 34s on Wed, 19 Sep, 03:25 PM Test Summary: 20 of 36281 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28368

  2. Mathias Brodala voted on patch set 2 CR +1 09/19/18, 13:27

  3. TYPO3com voted on patch set 2 V +1 09/19/18, 13:30 Completed build in 09m 56s on Wed, 19 Sep, 03:30 PM Test Summary: 35933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28371

  4. Benni Mack commented on patch set 3 09/19/18, 13:52

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 3 V -1 09/19/18, 14:00 Completed build in 08m 31s on Wed, 19 Sep, 04:00 PM Test Summary: 3 of 36281 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28375

  6. Anja Leichsenring commented on patch set 3 09/19/18, 14:59

    Benni, I did leave the GLOBAL assignment there on intention. No other way to test the new function. And it should not hurt, it will only override the assignment from the middleware before with the same value as the last one already set. In best case, this one is the first middleware to be processed, then we avoid errors by empty global var.
  7. Benni Mack commented on patch set 3 09/19/18, 15:00

    can you check how I did the tests in SiteResolver PSR-15 middleware? The handler could return a response containing the info, and you evaluate the response that is returned from the middleware.
  8. Anja Leichsenring commented on patch set 3 09/19/18, 15:03

    > Patch Set 3: > > can you check how I did the tests in SiteResolver PSR-15 middleware? > > The handler could return a response containing the info, and you evaluate the response that is returned from the middleware. but then I test the mocked resolver response. I want to test that the request object has not been changed and the call just fell through.
  9. Benni Mack commented on patch set 3 09/19/18, 15:05

    Sure, but do you want to keep an IMHO useless line of code that is executed every time in BE context (sure, this is no performance impact at all) for the sake of testing it like this? I don't have a better solution at hand right now, nothing better as the one you mentioned to test if the request is the same... but having prod code executed for having clean tests is ... "looks ugly" ;)
  10. Benni Mack commented on patch set 3 09/19/18, 15:05

    I'll see if I can spin sth up here... might have an idea.
  11. Benni Mack voted on patch set 3 CR -1 09/19/18, 15:06

  12. Benni Mack uploaded patch set 4 09/19/18, 15:15

  13. TYPO3com voted on patch set 4 V -1 09/19/18, 15:15 Completed build in 12s on Wed, 19 Sep, 05:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28386

  14. Anja Leichsenring uploaded patch set 5 09/19/18, 17:16

  15. TYPO3com voted on patch set 5 V +1 09/19/18, 17:25 Completed build in 09m 11s on Wed, 19 Sep, 07:25 PM Test Summary: 35981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28390

  16. Anja Leichsenring commented on patch set 5 09/19/18, 17:26

    jupp, that's better. Thank you! Should I vote now? Will you?
  17. Benni Mack voted on patch set 5 CR +1 09/20/18, 06:39

  18. Susi Moog commented on patch set 5 CR -1 09/20/18, 06:41

    SiteResolverTest.php:27

    please use testingframework base class...
  19. Susi Moog uploaded patch set 6 09/20/18, 06:56

  20. Susi Moog commented on patch set 5 09/20/18, 06:57

    SiteResolverTest.php:27 Reply

    Done
  21. TYPO3com voted on patch set 6 V +1 09/20/18, 07:07 Completed build in 10m 23s on Thu, 20 Sep, 09:07 AM Test Summary: 35993 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28421

  22. Susi Moog voted on patch set 6 V +1 CR +1 09/20/18, 07:19

  23. Tobi Kretschmann voted on patch set 6 V +1 CR +1 09/20/18, 07:33

  24. Susi Moog voted on patch set 6 V +2 CR +2 09/20/18, 07:33

  25. Susi Moog merged patch set 7 09/20/18, 07:33