Review TYPO3_8-7 Merged

58339[BUGFIX] Fetch configuration of FlexForm fields in edit wizard

Anja Leichsenring CR +2 V +2 Normal +52 −6 updated 09/20/18, 10:14

Commit message

Supply flex data structure identifier and current path to
editPopup field control to fetch correct TCA config if this
wizard is enabled for select or group fields in flex forms.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Anja Leichsenring uploaded patch set 1 09/19/18, 14:27

  2. TYPO3com voted on patch set 1 V -1 09/19/18, 14:27 Completed build in 09s on Wed, 19 Sep, 04:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2954

  3. Anja Leichsenring uploaded patch set 2 09/19/18, 14:28

  4. Anja Leichsenring commented on patch set 2 09/19/18, 14:28

    dirty manual backport. please give me a detailed review.
  5. TYPO3com voted on patch set 2 V +1 09/19/18, 14:35 Completed build in 07m 49s on Wed, 19 Sep, 04:35 PM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2955

  6. Christian Kuhn commented on patch set 2 CR -1 09/19/18, 14:38

    will re-test and review for v8
  7. Christian Kuhn voted on patch set 2 V +2 CR +2 09/20/18, 10:13

  8. Christian Kuhn merged patch set 3 09/20/18, 10:14