Review main Merged

58340[BUGFIX] Replace middlewares in stack on duplicate occurence

Susi Moog CR +2 V +2 Normal +67 −4 updated 09/20/18, 05:46

Commit message

Use array_replace_recursive instead of array_merge_recursive to
avoid an exception if a middleware is defined twice.

Additionally move the replacement out of the loop.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Richard Haeser +1
  • Verified V +2
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Susi Moog uploaded patch set 1 09/19/18, 14:40

  2. Susi Moog commented on patch set 1 CR -1 09/19/18, 14:46

    missing test
  3. TYPO3com voted on patch set 1 V +1 09/19/18, 14:53 Completed build in 12m 04s on Wed, 19 Sep, 04:53 PM Test Summary: 35978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28382

  4. Benjamin Franzke uploaded patch set 2 09/19/18, 19:53

  5. Benjamin Franzke commented on patch set 2 CR -1 09/19/18, 19:56

    MiddlewareStackResolver.php:105 Unresolved

    Will not work if $allMiddlewares is empty. Will push a change and a test for that.
  6. TYPO3com voted on patch set 2 V +1 09/19/18, 20:02 Completed build in 08m 23s on Wed, 19 Sep, 10:02 PM Test Summary: 35981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28400

  7. Benjamin Franzke uploaded patch set 3 09/19/18, 20:02

  8. Benjamin Franzke voted on patch set 3 V +1 CR +1 09/19/18, 20:03

  9. TYPO3com voted on patch set 3 V +1 09/19/18, 20:10 Completed build in 07m 58s on Wed, 19 Sep, 10:10 PM Test Summary: 35984 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28401

  10. Susi Moog commented on patch set 3 09/19/18, 20:35

    cool, thx for the test and the fix!
  11. Richard Haeser voted on patch set 3 V +1 CR +1 09/19/18, 21:14

  12. Georg Ringer voted on patch set 3 V +1 CR +1 09/20/18, 03:24

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 09/20/18, 05:46

  14. Andreas Kienast merged patch set 4 09/20/18, 05:46