58340[BUGFIX] Replace middlewares in stack on duplicate occurence
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Benjamin Franzke +1
- Georg Ringer +1
- Richard Haeser +1
-
Verified V +2
- Andreas Kienast +2
- Benjamin Franzke +1
- Georg Ringer +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1114
-
Susi Moog uploaded patch set 1 09/19/18, 14:40
-
Susi Moog commented on patch set 1 CR -1 09/19/18, 14:46
missing test -
TYPO3com voted on patch set 1 V +1 09/19/18, 14:53 Completed build in 12m 04s on Wed, 19 Sep, 04:53 PM Test Summary: 35978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28382
-
Benjamin Franzke uploaded patch set 2 09/19/18, 19:53
-
Benjamin Franzke commented on patch set 2 CR -1 09/19/18, 19:56
MiddlewareStackResolver.php:105UnresolvedWill not work if $allMiddlewares is empty. Will push a change and a test for that. -
TYPO3com voted on patch set 2 V +1 09/19/18, 20:02 Completed build in 08m 23s on Wed, 19 Sep, 10:02 PM Test Summary: 35981 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28400
-
Benjamin Franzke uploaded patch set 3 09/19/18, 20:02
-
Benjamin Franzke voted on patch set 3 V +1 CR +1 09/19/18, 20:03
-
TYPO3com voted on patch set 3 V +1 09/19/18, 20:10 Completed build in 07m 58s on Wed, 19 Sep, 10:10 PM Test Summary: 35984 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28401
-
Susi Moog commented on patch set 3 09/19/18, 20:35
cool, thx for the test and the fix! -
Richard Haeser voted on patch set 3 V +1 CR +1 09/19/18, 21:14
-
Georg Ringer voted on patch set 3 V +1 CR +1 09/20/18, 03:24
-
Andreas Kienast voted on patch set 3 V +2 CR +2 09/20/18, 05:46
-
Andreas Kienast merged patch set 4 09/20/18, 05:46