Review main Merged

58342[TASK] Streamline $TSFE->simUserGroup usages

Benni Mack CR +2 V +2 Normal +58 −25 updated 09/20/18, 09:32

Commit message

First, this patch streamlines some naming issue in $TSFE->applyPreviewSettings()
(introduced by myself).

On top, it sorts out the usages of $TSFE->simUserGroup within
EXT:adminpanel.

So far this patch is "just" cosmetics but allows to further
sort out "simUserGroup" in TYPO3 v10.0.

Review

  • Code review CR +2
    • Benni Mack +2
    • Tobi Kretschmann +1
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Benni Mack uploaded patch set 1 09/20/18, 06:27

  2. TYPO3com voted on patch set 1 V +1 09/20/18, 06:36 Completed build in 08m 44s on Thu, 20 Sep, 08:36 AM Test Summary: 35990 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28416

  3. Susi Moog uploaded patch set 2 09/20/18, 06:53

  4. TYPO3com voted on patch set 2 V +1 09/20/18, 07:01 Completed build in 08m 22s on Thu, 20 Sep, 09:01 AM Test Summary: 35993 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28420

  5. Anja Leichsenring voted on patch set 2 CR +1 09/20/18, 07:10

  6. Tobi Kretschmann commented on patch set 2 V +1 CR +1 09/20/18, 08:11

    still works as expected
  7. Benni Mack voted on patch set 2 V +2 CR +2 09/20/18, 09:32

  8. Benni Mack merged patch set 3 09/20/18, 09:32