Review main Merged

58343[TASK] Change visibility of PageRepository->init

Benni Mack CR +2 V +2 Easy +37 −5 updated 09/21/18, 09:38

Commit message

The init() method is now called implicitly within the constructor,
so the last part is to mark the method protected.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 1928

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 09/20/18, 06:37

  2. TYPO3com voted on patch set 1 V -1 09/20/18, 06:50 Completed build in 12m 18s on Thu, 20 Sep, 08:50 AM Test Summary: 3 of 36338 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28418

  3. Mathias Brodala updated the commit message in patch set 2 09/20/18, 07:35

  1. TYPO3com voted on patch set 2 V -1 09/20/18, 07:51 Completed build in 12m 06s on Thu, 20 Sep, 09:51 AM Test Summary: 3 of 36362 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28427

  2. Wouter Wolters uploaded patch set 3 09/20/18, 17:51

  3. Wouter Wolters uploaded patch set 4 09/20/18, 17:52

  4. TYPO3com voted on patch set 3 V -1 09/20/18, 18:00 Completed build in 08m 42s on Thu, 20 Sep, 08:00 PM Test Summary: 3 of 36444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28488

  5. TYPO3com voted on patch set 4 V -1 09/20/18, 18:05 Completed build in 13m 29s on Thu, 20 Sep, 08:05 PM Test Summary: 3 of 36444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28489

  6. Wouter Wolters uploaded patch set 5 09/20/18, 18:09

  7. TYPO3com voted on patch set 5 V -1 09/20/18, 18:18 Completed build in 09m 11s on Thu, 20 Sep, 08:18 PM Test Summary: 3 of 36444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28490

  8. Wouter Wolters uploaded patch set 6 09/20/18, 18:21

  9. TYPO3com voted on patch set 6 V -1 09/20/18, 18:30 Completed build in 09m 10s on Thu, 20 Sep, 08:30 PM Test Summary: 3 of 36444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28492

  10. Benni Mack uploaded patch set 7 09/20/18, 19:00

  11. Georg Ringer commented on patch set 7 CR -1 09/20/18, 19:08

    \TYPO3\CMS\Seo\Canonical\CanonicalGenerator seems to call that init as well
  12. TYPO3com voted on patch set 7 V +1 09/20/18, 19:15 Completed build in 14m 25s on Thu, 20 Sep, 09:15 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28495

  13. Benni Mack commented on patch set 7 09/20/18, 19:58

    aaah, great. I remove all usages, but don't deprecate - then new code gets added again :( Looks like we don't need RSTs anyways... I'll check that...
  14. Benni Mack uploaded patch set 8 09/20/18, 21:30

  15. TYPO3com voted on patch set 8 V +1 09/20/18, 21:37 Completed build in 07m 30s on Thu, 20 Sep, 11:37 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28504

  16. Wouter Wolters voted on patch set 8 V +1 CR +1 09/21/18, 07:01

  17. Anja Leichsenring voted on patch set 8 V +1 CR +1 09/21/18, 08:27

  18. Mathias Brodala commented on patch set 8 09/21/18, 08:32

    MethodCallMatcher.php:3442

    Is it a good idea to match this generic method name? /cc @lolli
  19. Anja Leichsenring commented on patch set 8 09/21/18, 08:51

    > Patch Set 8: > > (1 comment) true. I remove it, gimme 5 minutes.
  20. Anja Leichsenring commented on patch set 8 CR -1 09/21/18, 08:57

    on it
  21. Anja Leichsenring uploaded patch set 9 09/21/18, 08:59

  22. Anja Leichsenring voted on patch set 9 V +1 CR +1 09/21/18, 08:59

  23. TYPO3com voted on patch set 9 V +1 09/21/18, 09:10 Completed build in 11m 50s on Fri, 21 Sep, 11:10 AM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28507

  24. Christian Kuhn voted on patch set 9 V +2 CR +2 09/21/18, 09:38

  25. Christian Kuhn merged patch set 10 09/21/18, 09:38