Review main Merged

58344[TASK] Deprecate GeneralUtility::_GETset()

Benni Mack CR +2 V +2 Hard +214 −148 updated 09/27/18, 12:24

Commit message

The functionality of _GETset() is really broken by design
when thinking about having a non-global state.

On top $TSFE->mergingWithGetVars(), which was mainly used
in RealURL, is deprecated, as this needs to go within a PSR-15
middlware (I actually did that in a fork already for realurl v1).

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1016

  1. Benni Mack uploaded patch set 1 09/20/18, 06:47

  2. TYPO3com voted on patch set 1 V -1 09/20/18, 06:57 Completed build in 10m 39s on Thu, 20 Sep, 08:57 AM Test Summary: 87 of 36338 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28419

  3. Georg Ringer uploaded patch set 2 09/20/18, 13:27

  4. TYPO3com voted on patch set 2 V -1 09/20/18, 13:28 Completed build in 11s on Thu, 20 Sep, 03:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28460

  5. Georg Ringer uploaded patch set 3 09/20/18, 13:29

  6. TYPO3com voted on patch set 3 V -1 09/20/18, 13:40 Completed build in 10m 49s on Thu, 20 Sep, 03:40 PM Test Summary: 63 of 36349 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28461

  7. Benni Mack uploaded patch set 4 09/26/18, 16:13

  8. TYPO3com voted on patch set 4 V -1 09/26/18, 16:21 Completed build in 07m 37s on Wed, 26 Sep, 06:21 PM Test Summary: 39 of 36418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28657

  9. Benni Mack uploaded patch set 5 09/26/18, 23:31

  10. TYPO3com voted on patch set 5 V +1 09/26/18, 23:42 Completed build in 10m 37s on Thu, 27 Sep, 01:42 AM Test Summary: 36070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28700

  11. Frank Nägler uploaded patch set 6 09/27/18, 12:11

  12. Frank Nägler voted on patch set 6 V +1 CR +1 09/27/18, 12:12

  13. Andreas Kienast voted on patch set 6 V +1 CR +1 09/27/18, 12:18

  14. TYPO3com voted on patch set 6 V +1 09/27/18, 12:20 Completed build in 08m 59s on Thu, 27 Sep, 02:20 PM Test Summary: 36070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28714

  15. Andreas Kienast voted on patch set 6 V +2 CR +2 09/27/18, 12:24

  16. Andreas Kienast merged patch set 7 09/27/18, 12:24