Review TYPO3_8-7 Merged

58347[TASK] Update styleguide to 8.0.15

Christian Kuhn CR +2 V +2 Easy +8 −8 updated 09/20/18, 09:58

Commit message

A series of smaller patches have been applied to
v8 maintenance branch of the styleguide extension.

composer require --dev typo3/cms-styleguide:~8.0.15

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Christian Kuhn uploaded patch set 1 09/20/18, 09:40

  2. Mathias Brodala commented on patch set 1 09/20/18, 09:42

    composer.json:56

    Is the move from "require-dev" to "require" intentional?
  3. Christian Kuhn voted on patch set 1 CR -1 09/20/18, 09:45

  4. Christian Kuhn commented on patch set 1 09/20/18, 09:46

    composer.json:56 Reply

    shit. thx. ... no ... it's not ;)
  5. Christian Kuhn uploaded patch set 2 09/20/18, 09:47

  6. TYPO3com voted on patch set 1 V +1 09/20/18, 09:50 Completed build in 10m 02s on Thu, 20 Sep, 11:50 AM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2956

  7. Mathias Brodala voted on patch set 2 CR +1 09/20/18, 09:50

  8. TYPO3com voted on patch set 2 V +1 09/20/18, 09:57 Completed build in 09m 45s on Thu, 20 Sep, 11:57 AM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2957

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 09/20/18, 09:57

  10. Christian Kuhn merged patch set 3 09/20/18, 09:58