Review main Merged

58351[BUGFIX] Pass language mode to QuerySettings in default language too

Tymoteusz Motylewski CR +2 V +2 Hard +272 −267 updated 09/22/18, 19:48

Commit message

Introduction of the LanguageAspect changed the Extbase behavior, now it's
reintroduced.
When reviewing this patch please compare new code of
Typo3QuerySettings.php from this patch with state before
patch https://review.typo3.org/57424/ and compare
QueryLocalizedDataTest.php with one from v8 to see that
result is the same.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 2131

Show 46 earlier messages
  1. Tymoteusz Motylewski uploaded patch set 1 09/20/18, 13:35

  2. Tymoteusz Motylewski updated the commit message in patch set 2 09/20/18, 13:38

  3. Christian Kuhn commented on patch set 2 CR -1 09/20/18, 13:41

    needs a rebase now after the test patch https://review.typo3.org/#/c/58276/ has been merged.
  4. Tymoteusz Motylewski rebased onto patch set 3 09/20/18, 13:43

  5. TYPO3com voted on patch set 1 V -1 09/20/18, 13:44 Completed build in 08m 55s on Thu, 20 Sep, 03:44 PM Test Summary: 1013 of 36368 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28462

  6. TYPO3com voted on patch set 2 V -1 09/20/18, 13:50 Completed build in 11m 34s on Thu, 20 Sep, 03:50 PM Test Summary: 1013 of 36368 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28463

  1. TYPO3com voted on patch set 3 V -1 09/20/18, 13:59 Completed build in 14m 03s on Thu, 20 Sep, 03:59 PM Test Summary: 1091 of 36446 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28465

  2. Tymoteusz Motylewski uploaded patch set 4 09/20/18, 15:34

  3. TYPO3com voted on patch set 4 V -1 09/20/18, 15:45 Completed build in 10m 57s on Thu, 20 Sep, 05:45 PM Test Summary: 42 of 36443 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28477

  4. Tymoteusz Motylewski uploaded patch set 5 09/20/18, 15:56

  5. TYPO3com voted on patch set 5 V -1 09/20/18, 16:08 Completed build in 11m 32s on Thu, 20 Sep, 06:08 PM Test Summary: 27 of 36444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28480

  6. Markus Klein commented on patch set 5 09/20/18, 18:20

    Typo3QuerySettings.php:134

    do we have an L parameter in non-FE mode?
  7. Markus Klein commented on patch set 5 09/20/18, 18:20

    maybe lets put this link and information into the forge ticket? it's soo long
  8. Tymoteusz Motylewski commented on patch set 5 09/20/18, 18:26

    Typo3QuerySettings.php:134 Reply

    some people have ;) This code is in extbase since v6.0, so removig it would be breaking.
  9. Tymoteusz Motylewski commented on patch set 5 09/20/18, 18:27

    Typo3QuerySettings.php:134 Reply

    when reviewing this patch you shoudl actually compare "right" side of this patch with "left" side of https://review.typo3.org/#/c/57424/24/typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php
  10. Tymoteusz Motylewski uploaded patch set 6 09/20/18, 19:07

  11. TYPO3com voted on patch set 6 V -1 09/20/18, 19:17 Completed build in 10m 13s on Thu, 20 Sep, 09:17 PM Test Summary: 18 of 36447 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28496

  12. Tymoteusz Motylewski commented on patch set 6 CR -2 09/20/18, 20:33

    first https://review.typo3.org/#/c/58032/ needs to be merged and https://review.typo3.org/#/c/58276/ should be backported to v8
  13. Tymoteusz Motylewski commented on patch set 6 09/20/18, 20:51

    QueryLocalizedDataTest.php:1075

    this should be moved to global configuration
  14. Tymoteusz Motylewski uploaded patch set 7 09/21/18, 09:59

  15. TYPO3com voted on patch set 7 V -1 09/21/18, 10:29 Completed build in 13m 25s on Fri, 21 Sep, 12:29 PM Test Summary: 18 of 36447 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28518

  16. Tymoteusz Motylewski uploaded patch set 8 09/21/18, 20:42

  17. Tymoteusz Motylewski uploaded patch set 9 09/21/18, 20:48

  18. Tymoteusz Motylewski wrote 09/21/18, 20:48

    Removed Code-Review-2 by Tymoteusz Motylewski <t.motylewski@gmail.com>
  19. TYPO3com voted on patch set 8 V -1 09/21/18, 20:51 Completed build in 09m 38s on Fri, 21 Sep, 10:51 PM Test Summary: 24 of 36447 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28547

  20. TYPO3com voted on patch set 9 V +1 09/21/18, 20:57 Completed build in 08m 47s on Fri, 21 Sep, 10:57 PM Test Summary: 36099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28548

  21. Markus Klein updated the commit message in patch set 10 09/21/18, 21:05

  22. Markus Klein voted on patch set 10 V +1 CR +1 09/21/18, 21:05

  23. TYPO3com voted on patch set 10 V +1 09/21/18, 21:14 Completed build in 09m 09s on Fri, 21 Sep, 11:14 PM Test Summary: 36099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28550

  24. Anja Leichsenring voted on patch set 10 V +2 CR +2 09/22/18, 19:48

  25. Anja Leichsenring merged patch set 11 09/22/18, 19:48