Review main Merged

58353[BUGFIX] Silent upgrade wizard changes unrelated field definitions

Christian Kuhn CR +2 V +2 Normal +0 −72 updated 09/20/18, 14:58

Commit message

The silent upgrade wizard that should add missing cache
database tables also tends to change fields of not related
tables. The good thing is that this silent upgrader is
not really needed anymore since the "check for missing fields"
step that is always executed afterwards does find and create
cache tables, too.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
  • Verified V +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 710

  1. Christian Kuhn uploaded patch set 1 09/20/18, 14:25

  2. TYPO3com voted on patch set 1 V -1 09/20/18, 14:25 Completed build in 10s on Thu, 20 Sep, 04:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28469

  3. Christian Kuhn updated the commit message in patch set 2 09/20/18, 14:26

  4. TYPO3com voted on patch set 2 V -1 09/20/18, 14:26 Completed build in 13s on Thu, 20 Sep, 04:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28470

  5. Christian Kuhn uploaded patch set 3 09/20/18, 14:27

  6. TYPO3com voted on patch set 3 V +1 09/20/18, 14:35 Completed build in 08m 39s on Thu, 20 Sep, 04:35 PM Test Summary: 36095 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28471

  7. Frank Nägler voted on patch set 3 CR +1 09/20/18, 14:51

  8. Anja Leichsenring commented on patch set 3 V +1 CR +1 09/20/18, 14:54

    fixing bugs by removing code ^^
  9. Frank Nägler voted on patch set 3 V +2 CR +2 09/20/18, 14:58

  10. Frank Nägler merged patch set 4 09/20/18, 14:58