Review main Merged

58354[TASK] Add first acceptance test for sites module

Susi Moog CR +2 V +2 Normal +65 −0 updated 09/20/18, 16:18

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Susi Moog uploaded patch set 1 09/20/18, 15:28

  2. TYPO3com voted on patch set 1 V +1 09/20/18, 15:39 Completed build in 11m 13s on Thu, 20 Sep, 05:39 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28476

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/20/18, 15:41

  4. Georg Ringer voted on patch set 1 V +2 CR +2 09/20/18, 15:54

  5. Georg Ringer merged patch set 2 09/20/18, 15:54

  6. Benjamin Franzke commented on patch set 2 09/20/18, 16:18

    SiteModuleCest.php:3 Unresolved

    left-over from copy & paste – something for a drive-by in another related patch.