Review main Merged

58360[TASK] Remove a common set of false positives from extension scanner

Christian Kuhn CR +2 V +2 Easy +5 −39 updated 09/22/18, 16:51

Commit message

The patch removes a set of common methods and properties from
the extension scanner to show less weak matches:
* method init()
* class properties ->config, ->tmpl, ->id, ->returnUrl
Remember this only kicks methods and properties that are so common
that many extensions use them and there are more false positives
than actual matches.
Remember a green file does not mean nothing breaks and a red file does not
mean nothing works. It is not goal of the extension scanner to find
everything, and matches do not mean they are valid.
The above matcher configurations have only been removed since they 
use a naming that is often also used in extension. The places where they are
used in core are usually deep in the API and it is rather unlikely a match found
by the scanner does really mean the deprecated / removed method or property
rather than just a false positive due to the common naming.
Other matchers should still be kept, even if they show false
positives in specific cases.
It should not be a goal of an extension developer to make the
extension scanner green.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 811

  1. Christian Kuhn uploaded patch set 1 09/20/18, 19:43

  2. Christian Kuhn commented on patch set 1 09/20/18, 19:45

    note again: this is not a buy-out of the extension scanner. i've selected only those properties / methods that are so generic in its nameing that they are really liketly to be used by 3rd party extensions in itself, and the current deprecation / removal usages in the core are so deep that its rather unlikely that an extension really used the deprecated functionality.
  3. TYPO3com voted on patch set 1 V +1 09/20/18, 19:54 Completed build in 10m 35s on Thu, 20 Sep, 09:54 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28499

  4. Markus Klein commented on patch set 1 09/20/18, 20:53

    a red file does not mean nothing works.
    don't understand that part, please rephrase
  5. Christian Kuhn uploaded patch set 2 09/21/18, 09:34

  6. Anja Leichsenring updated the commit message in patch set 3 09/21/18, 09:42

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/21/18, 09:42

  8. TYPO3com voted on patch set 2 V +1 09/21/18, 09:45 Completed build in 10m 44s on Fri, 21 Sep, 11:45 AM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28509

  9. TYPO3com voted on patch set 3 V +1 09/21/18, 09:57 Completed build in 13m 46s on Fri, 21 Sep, 11:57 AM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28511

  10. Georg Ringer voted on patch set 3 V +2 CR +2 09/22/18, 16:51

  11. Georg Ringer merged patch set 4 09/22/18, 16:51