Review TYPO3_8-7 Merged

58362[TASK] Extend blog_example with relations

Tymoteusz Motylewski CR +2 V +2 Hard +413 −10 updated 09/21/18, 07:37

Commit message

* 1:1 inline relation csv (Post->additonalName)
* 1:1 inline relation foreign_field (Post->additonalInfo)
* 1:n inline relation csv (Post->additionalComments)
* n:1 group relation (Post->secondAuthor)

It also makes Person model translatable.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1

Issues 1

Files 11

Review log 1218

  1. Tymoteusz Motylewski uploaded patch set 1 09/20/18, 19:57

  2. TYPO3com voted on patch set 1 V -1 09/20/18, 20:03 Completed build in 05m 27s on Thu, 20 Sep, 10:03 PM Test Summary: 436 of 59837 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2961

  3. Tymoteusz Motylewski commented on patch set 2 09/20/18, 20:08

    Published edit on patch set 1.
  4. Tymoteusz Motylewski commented on patch set 3 09/20/18, 20:12

    Published edit on patch set 2.
  5. Tymoteusz Motylewski updated the commit message in patch set 4 09/20/18, 20:14

  6. TYPO3com voted on patch set 2 V -1 09/20/18, 20:15 Completed build in 06m 31s on Thu, 20 Sep, 10:15 PM Test Summary: 188 of 59837 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2962

  7. TYPO3com voted on patch set 3 V +1 09/20/18, 20:20 Completed build in 07m 51s on Thu, 20 Sep, 10:20 PM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2963

  8. TYPO3com voted on patch set 4 V +1 09/20/18, 20:22 Completed build in 07m 43s on Thu, 20 Sep, 10:22 PM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2964

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 09/20/18, 20:34

  10. Markus Klein commented on patch set 4 CR -1 09/20/18, 20:35

    tx_blogexample_domain_model_person.php:27

    lang
  11. Markus Klein uploaded patch set 5 09/20/18, 20:46

  12. Markus Klein voted on patch set 5 V +1 CR +1 09/20/18, 20:47

  13. TYPO3com voted on patch set 5 V +1 09/20/18, 20:53 Completed build in 06m 41s on Thu, 20 Sep, 10:53 PM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2965

  14. Anja Leichsenring uploaded patch set 6 09/21/18, 07:27

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 09/21/18, 07:28

  16. Markus Klein voted on patch set 6 V +2 CR +2 09/21/18, 07:31

  17. Markus Klein merged patch set 7 09/21/18, 07:31

  18. TYPO3com voted on patch set 6 V +1 09/21/18, 07:37 Completed build in 09m 05s on Fri, 21 Sep, 09:37 AM Test Summary: 59432 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2966