Review main Merged

58365[TASK] Improve install tool loading message

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 09/21/18, 10:16

Commit message

The first 'silent configuration update' ajax call in the install
tool does two things: As all others, it checks for a valid session,
if valid, it executes the update.
If session is not active, the 'enable install tool' file view is
loaded next. Not having a dedicated 'check session' call as first
step saves one ajax round trip.
The patch improves the status message to avoid confusion why the
silent configuration update is executed for login view.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Markus Klein +1

Issues 1

Files 1

Review log 69

  1. Christian Kuhn uploaded patch set 1 09/21/18, 09:51

  2. Christian Kuhn updated the commit message in patch set 2 09/21/18, 09:53

  3. Markus Klein updated the commit message in patch set 3 09/21/18, 09:54

  4. Markus Klein voted on patch set 3 V +1 CR +1 09/21/18, 09:54

  5. TYPO3com voted on patch set 1 V +1 09/21/18, 10:02 Completed build in 11m 11s on Fri, 21 Sep, 12:02 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28513

  6. Anja Leichsenring voted on patch set 3 V +2 CR +2 09/21/18, 10:03

  7. Anja Leichsenring merged patch set 4 09/21/18, 10:03

  8. TYPO3com voted on patch set 2 V +1 09/21/18, 10:12 Completed build in 15m 06s on Fri, 21 Sep, 12:12 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28514

  9. TYPO3com voted on patch set 3 V +1 09/21/18, 10:16 Completed build in 19m 43s on Fri, 21 Sep, 12:16 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28515