Review main Merged

58369[BUGFIX] Use proper events to trigger HTML5 validation in Install Tool

Andreas Kienast CR +2 V +2 Normal +34 −31 updated 09/21/18, 18:37

Commit message

The actions "Create admin" and "Change install tool password" now listen
to the `submit` event of their respective form to allow using the
HTML5-based field validation.

Review

  • Code review CR +2
    • Markus Klein +2
    • Guido Schmechel +1
  • Verified V +2
    • Markus Klein +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Andreas Kienast uploaded patch set 1 09/21/18, 10:56

  2. TYPO3com voted on patch set 1 V +1 09/21/18, 11:25 Completed build in 24m 24s on Fri, 21 Sep, 01:25 PM Test Summary: 36096 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28532

  3. Guido Schmechel voted on patch set 1 V +1 CR +1 09/21/18, 17:37

  4. Markus Klein voted on patch set 1 V +2 CR +2 09/21/18, 18:37

  5. Markus Klein merged patch set 2 09/21/18, 18:37