Review main Merged

58379[BUGFIX] Use right keys in typeicon_classes for site_errorhandling table

Jigal van Hemert CR +2 V +2 Easy +2 −2 updated 09/24/18, 04:13

Commit message

The IRRE records show an icon depending on the type of error handler that
is configured. Because the wrong keys were used only the default
"not found" icon was displayed.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Jigal van Hemert uploaded patch set 1 09/23/18, 15:09

  2. TYPO3com voted on patch set 1 V +1 09/23/18, 15:18 Completed build in 08m 36s on Sun, 23 Sep, 05:18 PM Test Summary: 36099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28561

  3. Josef Glatz voted on patch set 1 V +1 CR +1 09/23/18, 18:46

  4. Josef Glatz commented on patch set 1 09/23/18, 18:47

    Works! Beside that, would it be good to have also a default icon if there is no type selected? Feels broken on a first look
  5. Benni Mack voted on patch set 1 V +2 CR +2 09/24/18, 04:13

  6. Benni Mack merged patch set 2 09/24/18, 04:13