Review main Merged

58396[BUGFIX] adminpanel: Do not use getTSConfig in a deprecated way

Benjamin Franzke CR +2 V +2 Easy +5 −5 updated 09/26/18, 11:16

Commit message

Since https://review.typo3.org/56968 handing over arguments
to getTSConfig() is deprecated.

As a drive-by we also fix some related wrong getTSConfig() mocks
in Unit/Middleware/AdminPanelInitiatorTest.php – they do not
produce errors, but these mocks are too unspecific, as they
still allow an argument to be passed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Susi Moog +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 67

  1. Benjamin Franzke uploaded patch set 1 09/26/18, 07:05

  2. TYPO3com voted on patch set 1 V +1 09/26/18, 07:15 Completed build in 10m 16s on Wed, 26 Sep, 09:15 AM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28638

  3. Susi Moog voted on patch set 1 CR +1 09/26/18, 07:49

  4. Markus Klein voted on patch set 1 V +1 CR +1 09/26/18, 09:48

  5. Wouter Wolters voted on patch set 1 CR +1 09/26/18, 09:52

  6. Georg Ringer voted on patch set 1 V +2 CR +2 09/26/18, 11:16

  7. Georg Ringer merged patch set 2 09/26/18, 11:16