Review main Merged

58397[BUGFIX] Allow linking to a targetSite without currentSite

Susi Moog CR +2 V +2 Easy +6 −4 updated 09/27/18, 13:09

Commit message

In case no current site exists in a context (for example currently
eID or other scripting contexts), the pageLinkBuilder threw an error
when linking to a page with a site configuration. The necessity for
having a current site config has been removed, the pageLinkBuilder
can now be used without a current site object and will then always
generate absolute URLs to the target site.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Henning Liebe +1
  • Verified V +2
    • Frank Nägler +2
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Susi Moog uploaded patch set 1 09/26/18, 08:51

  2. TYPO3com voted on patch set 1 V +1 09/26/18, 09:01 Completed build in 09m 19s on Wed, 26 Sep, 11:01 AM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28640

  3. Anja Leichsenring voted on patch set 1 CR +1 09/27/18, 10:09

  4. Henning Liebe commented on patch set 1 V +1 CR +1 09/27/18, 12:55

    works for me
  5. Frank Nägler voted on patch set 1 CR +1 09/27/18, 13:05

  6. Frank Nägler voted on patch set 1 V +1 09/27/18, 13:08

  7. Frank Nägler voted on patch set 1 V +2 CR +2 09/27/18, 13:09

  8. Frank Nägler merged patch set 2 09/27/18, 13:09