Review main Merged

58400[BUGFIX] Fix formEngine SelectCheckBox word-wrap on small screens

Josef Glatz CR +2 V +2 Easy +1 −1 updated 09/27/18, 13:19

Commit message

This patch enables word-wrap in a form element `type=select`
with `renderType=selectCheckBox` on small screen devices like
tablet portrait. It prevents the list from sticking out of the right
viewport border.

Only the case when TYPO3_CONF_VARS/BE/debug = false was
taken into account.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Georg Tiefenbrunn +1
    • Georg Ringer +1
    • Michael Oehlhof +1
  • Verified V +2
    • Frank Nägler +2
    • Georg Tiefenbrunn +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Josef Glatz uploaded patch set 1 09/26/18, 17:00

  2. TYPO3com voted on patch set 1 V +1 09/26/18, 17:10 Completed build in 09m 46s on Wed, 26 Sep, 07:10 PM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28661

  3. Georg Ringer voted on patch set 1 V +1 CR +1 09/26/18, 18:15

  4. Georg Tiefenbrunn voted on patch set 1 V +1 CR +1 09/26/18, 19:04

  5. Michael Oehlhof voted on patch set 1 CR +1 09/26/18, 20:30

  6. Frank Nägler voted on patch set 1 V +2 CR +2 09/27/18, 13:19

  7. Frank Nägler merged patch set 2 09/27/18, 13:19