Review main Merged

58401[TASK] Add facades for symfony/routing components

Benni Mack CR +2 V +2 Normal +143 −56 updated 09/26/18, 18:41

Commit message

We heavily rely on Symfony Routing for TYPO3 routing,
however we want to encapsulate this as much as possible
to allow us to use a different routing system if a better one
comes up.

In order to proceed with Route Enhancers we introduce
our own objects to extend them, and to typehint against
these objects in the next patches.

Some minor code preparations have been made as well.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Georg Ringer +1
  • Verified V +2
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 912

  1. Benni Mack uploaded patch set 1 09/26/18, 17:42

  2. Benni Mack uploaded patch set 2 09/26/18, 17:49

  3. Oliver Hader voted on patch set 2 CR +1 09/26/18, 17:52

  4. TYPO3com voted on patch set 1 V -1 09/26/18, 17:55 Completed build in 12m 49s on Wed, 26 Sep, 07:55 PM Test Summary: 12 of 36450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28665

  5. Georg Ringer voted on patch set 2 V +1 CR +1 09/26/18, 17:58

  6. TYPO3com voted on patch set 2 V -1 09/26/18, 18:02 Completed build in 13m 16s on Wed, 26 Sep, 08:02 PM Test Summary: 867 of 36450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28667

  7. Benni Mack uploaded patch set 3 09/26/18, 18:25

  8. TYPO3com voted on patch set 3 V +1 09/26/18, 18:36 Completed build in 11m 02s on Wed, 26 Sep, 08:36 PM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28670

  9. Georg Ringer voted on patch set 3 V +1 CR +1 09/26/18, 18:37

  10. Oliver Hader voted on patch set 3 CR +1 09/26/18, 18:38

  11. Oliver Hader voted on patch set 3 V +2 CR +2 09/26/18, 18:41

  12. Oliver Hader merged patch set 4 09/26/18, 18:41