58401[TASK] Add facades for symfony/routing components
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Georg Ringer +1
-
Verified V +2
- Oliver Hader +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Routing/PageRouter.php+52 −31
- typo3/sysext/core/Classes/Routing/Route.phpnew+35 −0
- typo3/sysext/core/Classes/Routing/RouteCollection.phpnew+28 −0
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+0 −2
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −1
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+15 −14
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php+10 −6
Review log 912
-
Benni Mack uploaded patch set 1 09/26/18, 17:42
-
Benni Mack uploaded patch set 2 09/26/18, 17:49
-
Oliver Hader voted on patch set 2 CR +1 09/26/18, 17:52
-
TYPO3com voted on patch set 1 V -1 09/26/18, 17:55 Completed build in 12m 49s on Wed, 26 Sep, 07:55 PM Test Summary: 12 of 36450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28665
-
Georg Ringer voted on patch set 2 V +1 CR +1 09/26/18, 17:58
-
TYPO3com voted on patch set 2 V -1 09/26/18, 18:02 Completed build in 13m 16s on Wed, 26 Sep, 08:02 PM Test Summary: 867 of 36450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28667
-
Benni Mack uploaded patch set 3 09/26/18, 18:25
-
TYPO3com voted on patch set 3 V +1 09/26/18, 18:36 Completed build in 11m 02s on Wed, 26 Sep, 08:36 PM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28670
-
Georg Ringer voted on patch set 3 V +1 CR +1 09/26/18, 18:37
-
Oliver Hader voted on patch set 3 CR +1 09/26/18, 18:38
-
Oliver Hader voted on patch set 3 V +2 CR +2 09/26/18, 18:41
-
Oliver Hader merged patch set 4 09/26/18, 18:41