Review main Merged

58402[TASK] Mitigate argon2i hash issues

Christian Kuhn CR +2 V +2 Normal +49 −27 updated 09/27/18, 13:01

Commit message

* Let the "stored hash uses not supported mechanism" bubble up.
  Instead of just a "login failed", an error is raised hinting
  that something is broken.
* Improve exception message #1533818591: If an upgrade or new
  installation has been performed on a system that does support
  argon2i, users are upgraded to this mechanism. If the instance
  is later deployed to a server that does not support argon2i, the
  hash comparison will fail.
* Improve exception message #1533822084: This one is usually only
  raised if a core upgrade from v8 to v9 has just been performed on
  an instance that does not support argon2i, and a backend login is
  executed before the install tool silent configuration upgrader
  configured the system properly.
* Wiki pages with more details:
  https://wiki.typo3.org/Exception/CMS/1533818591
  https://wiki.typo3.org/Exception/CMS/1533822084

Review

  • Code review CR +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1518

  1. Christian Kuhn uploaded patch set 1 09/26/18, 17:49

  2. TYPO3com voted on patch set 1 V -1 09/26/18, 17:59 Completed build in 10m 26s on Wed, 26 Sep, 07:59 PM Test Summary: 3 of 36450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28666

  3. Christian Kuhn uploaded patch set 2 09/26/18, 18:13

  4. TYPO3com voted on patch set 2 V +1 09/26/18, 18:25 Completed build in 11m 47s on Wed, 26 Sep, 08:25 PM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28669

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/27/18, 12:14

  6. Andreas Kienast voted on patch set 2 CR +1 09/27/18, 12:21

  7. Frank Nägler commented on patch set 2 CR -1 09/27/18, 12:25

    AuthenticationService.php:182

    The variable $invalidPasswordHashException might have not been defined
  8. Frank Nägler commented on patch set 2 09/27/18, 12:28

    AuthenticationService.php:182 Reply

    the variable could be null, in this case PHP will fatal: Fatal error: Uncaught Error: Can only throw objects
  9. Christian Kuhn commented on patch set 2 09/27/18, 12:37

    AuthenticationService.php:182 Reply

    uh? imho there is no code path to reach that without having some exception. how to reproduce?
  10. Christian Kuhn commented on patch set 2 09/27/18, 12:44

    AuthenticationService.php:182 Reply

    ok, can't happen. but to happify frank and phpstrom ... i'll test for null here.
  11. Christian Kuhn voted on patch set 2 CR -1 09/27/18, 12:44

  12. Christian Kuhn uploaded patch set 3 09/27/18, 12:45

  13. Andreas Kienast voted on patch set 3 CR +1 09/27/18, 12:50

  14. Frank Nägler voted on patch set 3 V +1 CR +1 09/27/18, 12:55

  15. TYPO3com voted on patch set 3 V +1 09/27/18, 12:55 Completed build in 09m 23s on Thu, 27 Sep, 02:55 PM Test Summary: 36070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28717

  16. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/27/18, 12:57

  17. Frank Nägler voted on patch set 3 V +2 CR +2 09/27/18, 13:01

  18. Frank Nägler merged patch set 4 09/27/18, 13:01