58402[TASK] Mitigate argon2i hash issues
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Anja Leichsenring +1
- Andreas Kienast +1
-
Verified V +2
- Frank Nägler +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php4+29 −22
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PasswordHashFactory.php+8 −2
- typo3/sysext/core/Tests/Unit/Authentication/AuthenticationServiceTest.php+5 −2
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+7 −1
Review log 1518
-
Christian Kuhn uploaded patch set 1 09/26/18, 17:49
-
TYPO3com voted on patch set 1 V -1 09/26/18, 17:59 Completed build in 10m 26s on Wed, 26 Sep, 07:59 PM Test Summary: 3 of 36450 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28666
-
Christian Kuhn uploaded patch set 2 09/26/18, 18:13
-
TYPO3com voted on patch set 2 V +1 09/26/18, 18:25 Completed build in 11m 47s on Wed, 26 Sep, 08:25 PM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28669
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 09/27/18, 12:14
-
Andreas Kienast voted on patch set 2 CR +1 09/27/18, 12:21
-
Frank Nägler commented on patch set 2 CR -1 09/27/18, 12:25
-
Frank Nägler commented on patch set 2 09/27/18, 12:28
AuthenticationService.php:182Replythe variable could be null, in this case PHP will fatal: Fatal error: Uncaught Error: Can only throw objects -
Christian Kuhn commented on patch set 2 09/27/18, 12:37
AuthenticationService.php:182Replyuh? imho there is no code path to reach that without having some exception. how to reproduce? -
Christian Kuhn commented on patch set 2 09/27/18, 12:44
AuthenticationService.php:182Replyok, can't happen. but to happify frank and phpstrom ... i'll test for null here. -
Christian Kuhn voted on patch set 2 CR -1 09/27/18, 12:44
-
Christian Kuhn uploaded patch set 3 09/27/18, 12:45
-
Andreas Kienast voted on patch set 3 CR +1 09/27/18, 12:50
-
Frank Nägler voted on patch set 3 V +1 CR +1 09/27/18, 12:55
-
TYPO3com voted on patch set 3 V +1 09/27/18, 12:55 Completed build in 09m 23s on Thu, 27 Sep, 02:55 PM Test Summary: 36070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28717
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 09/27/18, 12:57
-
Frank Nägler voted on patch set 3 V +2 CR +2 09/27/18, 13:01
-
Frank Nägler merged patch set 4 09/27/18, 13:01
AuthenticationService.php:182