58404[BUGFIX] VimeoRenderer render private links
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jörg Bösche +1
-
Verified V +2
- Markus Klein +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1417
-
Guido Schmechel uploaded patch set 1 09/26/18, 18:26
-
TYPO3com voted on patch set 1 V +1 09/26/18, 18:38 Completed build in 11m 47s on Wed, 26 Sep, 08:38 PM Test Summary: 36105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28671
-
Josef Glatz commented on patch set 1 V +1 CR +1 09/26/18, 18:42
Nice catch! -
Markus Klein commented on patch set 1 CR -1 09/27/18, 05:52
VimeoHelper.php:75Please document in the comment above which kind of <code> we would like to accept here. Futhermore I suggest changing the regex to: '#vimeo\.com/(?:video/)?([0-9a-z/]+)#i' below $matches[1] is to be used then.VimeoRendererTest.php:234this test does not cover the changed part. if you revert the code change in the other file, the test won't fail. I would rather add a test for the transformUrlToFile method. -
Josef Glatz voted on patch set 1 V 0 CR 0 09/27/18, 06:06
-
Guido Schmechel commented on patch set 1 09/27/18, 08:45
Thanks! I will have a look at it. -
Guido Schmechel uploaded patch set 2 09/27/18, 21:30
-
Guido Schmechel uploaded patch set 3 09/27/18, 21:32
-
TYPO3com voted on patch set 2 V +1 09/27/18, 21:46 Completed build in 12m 00s on Thu, 27 Sep, 11:46 PM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28768
-
TYPO3com voted on patch set 3 V +1 09/27/18, 21:50 Completed build in 16m 08s on Thu, 27 Sep, 11:50 PM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28769
-
Frans Saris commented on patch set 3 09/28/18, 05:10
Fetching preview images also work with these id's? -
Guido Schmechel commented on patch set 3 09/28/18, 06:52
> Patch Set 3: > > Fetching preview images also work with these id's? Yes. See https://vimeo.com/api/oembed.json?width=2048&url=https://vimeo.com/202284380/dfddc03daf -
Markus Klein voted on patch set 3 V +1 CR +1 09/28/18, 12:01
-
Jörg Bösche voted on patch set 3 V +1 CR +1 09/28/18, 12:05
-
Markus Klein voted on patch set 3 V +2 CR +2 09/28/18, 12:06
-
Markus Klein merged patch set 4 09/28/18, 12:07
-
Markus Klein commented on patch set 4 09/28/18, 12:07
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1bdc3ecc8f82493b82e7d987431b73ef801c3002