Review main Merged

58404[BUGFIX] VimeoRenderer render private links

Guido Schmechel CR +2 V +2 Normal +112 −4 updated 09/28/18, 12:07

Commit message

Now it is also possible to add private Vimeo links.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jörg Bösche +1
  • Verified V +2
    • Markus Klein +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1417

  1. Guido Schmechel uploaded patch set 1 09/26/18, 18:26

  2. TYPO3com voted on patch set 1 V +1 09/26/18, 18:38 Completed build in 11m 47s on Wed, 26 Sep, 08:38 PM Test Summary: 36105 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28671

  3. Josef Glatz commented on patch set 1 V +1 CR +1 09/26/18, 18:42

    Nice catch!
  4. Markus Klein commented on patch set 1 CR -1 09/27/18, 05:52

    VimeoHelper.php:75

    Please document in the comment above which kind of <code> we would like to accept here. Futhermore I suggest changing the regex to: '#vimeo\.com/(?:video/)?([0-9a-z/]+)#i' below $matches[1] is to be used then.

    VimeoRendererTest.php:234

    this test does not cover the changed part. if you revert the code change in the other file, the test won't fail. I would rather add a test for the transformUrlToFile method.
  5. Josef Glatz voted on patch set 1 V 0 CR 0 09/27/18, 06:06

  6. Guido Schmechel commented on patch set 1 09/27/18, 08:45

    Thanks! I will have a look at it.
  7. Guido Schmechel uploaded patch set 2 09/27/18, 21:30

  8. Guido Schmechel uploaded patch set 3 09/27/18, 21:32

  9. TYPO3com voted on patch set 2 V +1 09/27/18, 21:46 Completed build in 12m 00s on Thu, 27 Sep, 11:46 PM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28768

  10. TYPO3com voted on patch set 3 V +1 09/27/18, 21:50 Completed build in 16m 08s on Thu, 27 Sep, 11:50 PM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28769

  11. Frans Saris commented on patch set 3 09/28/18, 05:10

    Fetching preview images also work with these id's?
  12. Guido Schmechel commented on patch set 3 09/28/18, 06:52

    > Patch Set 3: > > Fetching preview images also work with these id's? Yes. See https://vimeo.com/api/oembed.json?width=2048&url=https://vimeo.com/202284380/dfddc03daf
  13. Markus Klein voted on patch set 3 V +1 CR +1 09/28/18, 12:01

  14. Jörg Bösche voted on patch set 3 V +1 CR +1 09/28/18, 12:05

  15. Markus Klein voted on patch set 3 V +2 CR +2 09/28/18, 12:06

  16. Markus Klein merged patch set 4 09/28/18, 12:07

  17. Markus Klein commented on patch set 4 09/28/18, 12:07

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1bdc3ecc8f82493b82e7d987431b73ef801c3002