58406[BUGFIX] Sql query export to use search_result_labels setting
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Frank Nägler +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1315
-
Sascha Löffler uploaded patch set 1 09/26/18, 22:44
-
TYPO3com voted on patch set 1 V +1 09/26/18, 22:54 Completed build in 09m 35s on Thu, 27 Sep, 12:54 AM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28697
-
Tymoteusz Motylewski updated the commit message in patch set 2 09/27/18, 09:57
-
Tymoteusz Motylewski commented on patch set 2 09/27/18, 09:58
I've added 8.7 to the releases, so the patch is backported after the merge. -
TYPO3com voted on patch set 2 V +1 09/27/18, 10:07 Completed build in 09m 55s on Thu, 27 Sep, 12:07 PM Test Summary: 36102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28712
-
Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 09/28/18, 12:41
-
Tymoteusz Motylewski commented on patch set 2 09/28/18, 12:46
well, for me the default was that strings were not formatted, and after I selected the checkbox the export changed and values started to be formatted. -
Sascha Löffler commented on patch set 2 09/28/18, 13:26
Not sure if i understand you correctly. But in TYPO3 v8, the labels where always used because the setting search_result_labels was always set to 1. in TYPO3 v9 it was the same, however the QueryView now accessed a different settings array, and as such the condition was always false and never used the search_result_labels setting. -
Tymoteusz Motylewski commented on patch set 2 09/28/18, 20:33
I mean that according to your description, without this patch the exported data should always convert uids like pid to labels. which is not the case in master. In master without the patch you always get plain uids, and the checkbox does nothing, with the patch it works. -
Frank Nägler voted on patch set 2 V +1 CR +1 09/29/18, 11:24
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 09/29/18, 12:03
-
Tymoteusz Motylewski merged patch set 3 09/29/18, 12:03
-
Stephan Großberndt commented on patch set 3 10/27/18, 15:28
Backport to 8.7 is missing -
Sascha Löffler commented on patch set 3 10/31/18, 14:19
Sorry. New to Backporting here. I did understand it if it is backported "automagically" after the merge. Have i forgotten something? -
Wouter Wolters commented on patch set 3 10/31/18, 14:22
You did nothing wrong Sascha, Tymek, the merger of this patch, should have done the backport. But maybe there is a reason for the missing backport. Lets wait for Tymek to respond here.